Repository navigation
cpnet: make cpnet_newIPVxAddress() return NULL on failure - #84
Merged
Merged
Conversation
Both cpnet_newIPV4Address() and cpnet_newIPV6Address() used the result of JCL_malloc() without checking it, so when the allocation failed they dereferenced NULL and crashed the VM. Make them return NULL on failure, with the OutOfMemoryError pending, and check the result in their callers: - cpnet_aton() returns ENOMEM. VMInetAddress.aton() now throws UnknownHostException only if no exception is pending, so the OutOfMemoryError is kept. - VMInetAddress.lookupInaddrAny(), VMInetAddress.getHostByAddr() and _javanet_get_ip_netaddr() release the address bytes and return with the OutOfMemoryError pending. Signed-off-by: Guillermo Rodríguez <grodriguez@ingelabs.com>
phvega
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both cpnet_newIPV4Address() and cpnet_newIPV6Address() used the result of JCL_malloc() without checking it, so when the allocation failed they dereferenced NULL and crashed the VM. Make them return NULL on failure, with the OutOfMemoryError pending, and check the result in their callers: