Repository navigation
cpnet: also free the array when freeing an array of addresses - #80
Merged
Merged
Conversation
cpnet_freeAddresses() freed each address in the supplied array, but not the array itself. The error path in cpnet_getHostByName() did free the array, but none of the callers in VMInetAddress did, so every successful host name lookup leaked the array. Rename the function to cpnet_freeAddressArray() and have it free the array too. The new name makes the intent clear, which should help avoiding this kind of leaks in the future. Signed-off-by: Guillermo Rodríguez <grodriguez@ingelabs.com>
phvega
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpnet_freeAddresses() freed each address in the supplied array, but not the array itself. The error path in cpnet_getHostByName() did free the array, but none of the callers in VMInetAddress did, so every successful host name lookup leaked the array.
Rename the function to cpnet_freeAddressArray() and have it free the array too. The new name makes the intent clear, which should help avoiding this kind of leaks in the future.