Skip to content

Remove unnecessary cast with numpy 2.5.4 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Oct 18, 2026
Merged

Remove unnecessary cast with numpy 2.5.4 #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eddb68
fix: remove unnecessary cast with numpy 2.5.4
alexfikl Oct 18, 2026
43c5894
chore: update baseline
alexfikl Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .basedpyright/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11651,14 +11651,6 @@
"lineCount": 1
}
},
{
"code": "reportUnusedClass",
"range": {
"startColumn": 10,
"endColumn": 41,
"lineCount": 1
}
},
{
"code": "reportInvalidCast",
"range": {
Expand Down
3 changes: 1 addition & 2 deletions arraycontext/impl/pytato/outline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
if TYPE_CHECKING:
from collections.abc import Callable, Mapping

from pymbolic import Scalar
from pytools.tag import Tag

from arraycontext.impl.pytato import _BasePytatoArrayContext
Expand Down Expand Up @@ -152,7 +151,7 @@ def get_placeholder_replacement(
if arg is None:
return None
elif np.isscalar(arg):
return cast("Scalar", arg)
return arg
elif isinstance(arg, pt.Array):
return arg_id_to_placeholder[key]
elif is_array_container_type(arg.__class__):
Expand Down
Loading