Repository navigation
feat!: share linting defaults and remove local action helpers - #607
Merged
Merged
Conversation
Use the shared Super-Linter image for local and CI linting. Adopt native self-repository references and remove redundant sibling-action setup. BREAKING CHANGE: remove actions/local-actions and actions/local-workflow-actions. Replace their setup steps and filesystem references with $/ paths relative to the defining repository root. Self-repository references require GitHub.com and Actions runner 2.336.0 or newer.
Contributor
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
Pin the local Dockerfile and reusable linter workflow to the same verified Super-Linter 1.1.0 digest so Ratchet accepts the Docker action reference. Document that both the version and digest must stay aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local and CI linting duplicate toolchain selection, Kubernetes schema defaults, and commitlint setup. Both now use
ghcr.io/hoverkraft-tech/docker-base-images/super-linter:1.1.0, so those defaults are maintained in the image repository. Native$/references also replace the filesystem helpers used to expose sibling actions.linter-envoverrides to the image, removing duplicated configuration logic.$/and enable Zizmor's self-repository audit.actions/local-actionsandactions/local-workflow-actions, including their implementation, tests, package files, and documentation. Remove sibling-action preparation and cleanup from the comment and pull-request actions.BREAKING CHANGE:
actions/local-actionsandactions/local-workflow-actionsare no longer available. Consumers must remove these helper steps and reference actions directly with$/, relative to the defining repository's root. Remove any dependencies on the helpers' exposed paths or outputs. Self-repository references require GitHub.com and GitHub Actions runner 2.336.0 or newer.For example:
These replace
./../self-actions/get-issue-numberand./../self-workflow/.github/actions/example, respectively. Callers pinned to existing tags or commit SHAs retain the previous actions.Validation:
make ci: dependency installation, audit, linting, and all 83 remaining tests pass.git diff --checkpasses.Reference: GitHub self-repository syntax.