Skip to content

feat!: share linting defaults and remove local action helpers - #607

Merged
neilime merged 2 commits into
mainfrom
feat/shared-linting-self-repository
Oct 12, 2026
Merged

neilime merged 2 commits into
mainfrom
feat/shared-linting-self-repository

Conversation

@neilime

@neilime neilime commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Local and CI linting duplicate toolchain selection, Kubernetes schema defaults, and commitlint setup. Both now use ghcr.io/hoverkraft-tech/docker-base-images/super-linter:1.1.0, so those defaults are maintained in the image repository. Native $/ references also replace the filesystem helpers used to expose sibling actions.

  • Run the shared image from the reusable linter workflow and local Dockerfile, with both references pinned to the same registry-verified SHA256 digest. Forward toolchain inputs and linter-env overrides to the image, removing duplicated configuration logic.
  • Convert 30 internal action and reusable-workflow references to $/ and enable Zizmor's self-repository audit.
  • Remove actions/local-actions and actions/local-workflow-actions, including their implementation, tests, package files, and documentation. Remove sibling-action preparation and cleanup from the comment and pull-request actions.

BREAKING CHANGE: actions/local-actions and actions/local-workflow-actions are no longer available. Consumers must remove these helper steps and reference actions directly with $/, relative to the defining repository's root. Remove any dependencies on the helpers' exposed paths or outputs. Self-repository references require GitHub.com and GitHub Actions runner 2.336.0 or newer.

For example:

# Sibling action in a composite action
- uses: $/actions/get-issue-number

# Action belonging to a reusable workflow's repository
- uses: $/.github/actions/example

These replace ./../self-actions/get-issue-number and ./../self-workflow/.github/actions/example, respectively. Callers pinned to existing tags or commit SHAs retain the previous actions.

Validation:

  • make ci: dependency installation, audit, linting, and all 83 remaining tests pass.
  • Ratchet 0.12.0: all workflow and action references pass pinning validation.
  • Commitlint: the fix commit message passes validation.
  • All 30 self-repository references resolve to existing actions or workflows.
  • No references to the removed helpers remain; git diff --check passes.
  • GitHub-hosted workflow execution will be validated by this PR's CI.

Reference: GitHub self-repository syntax.

Use the shared Super-Linter image for local and CI linting. Adopt native
self-repository references and remove redundant sibling-action setup.

BREAKING CHANGE: remove actions/local-actions and actions/local-workflow-actions.
Replace their setup steps and filesystem references with $/ paths relative
to the defining repository root. Self-repository references require
GitHub.com and Actions runner 2.336.0 or newer.
@neilime neilime added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Oct 11, 2026
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
DOCKERFILE_HADOLINT Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
MARKDOWN Pass ✅
MARKDOWN_PRETTIER Pass ✅
NATURAL_LANGUAGE Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter
Super-linter revision: 2da136927bd4a73596db63044b504547c62cb854
Super-linter version: 9.0.0

@neilime neilime changed the title feat: share linting defaults and remove local action helpers (breaking change) feat!: share linting defaults and remove local action helpers (breaking change) Oct 12, 2026
@neilime neilime changed the title feat!: share linting defaults and remove local action helpers (breaking change) feat!: share linting defaults and remove local action helpers Oct 12, 2026
Pin the local Dockerfile and reusable linter workflow to the same verified
Super-Linter 1.1.0 digest so Ratchet accepts the Docker action reference.
Document that both the version and digest must stay aligned.
@neilime
neilime merged commit a3ee349 into main Oct 12, 2026
48 checks passed
@neilime
neilime deleted the feat/shared-linting-self-repository branch October 12, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant