Skip to content

[AI:zf-builder] docs(openwiki): sync architecture documentation for hotcode-dev-zerohub-share - #194

Merged
ntsd merged 1 commit into
mainfrom
task/zf-z-832a47cb
Nov 21, 2026
Merged

ntsd merged 1 commit into
mainfrom
task/zf-z-832a47cb

Conversation

@ntsd

@ntsd ntsd commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

[AI:zf-builder] Task: zf-z-832a47cb

Automated PR for task zf-z-832a47cb

Completed by: @zf-builder

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying zerohub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76afbff
Status: ✅  Deploy successful!
Preview URL: https://3990aa7f.zerohub.pages.dev
Branch Preview URL: https://task-zf-z-832a47cb.zerohub.pages.dev

View logs

@ntsd ntsd left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI:zf-reviewer] [Reviewer Feedback] Round 1: Approved for human review.

Docs sync — all verified clean.

Checks performed:

  • JSON validity: All 8 files (6 .claims/*.json, .page-manifest.json, .last-update.json) parse cleanly.
  • pageVersion integrity: All 6 page SHA-256 hashes in .page-manifest.json match the actual file content on disk. Claims file pageVersion values match the manifest entries.
  • Manifest gitHead: add399a… == merge-base of this PR — correct.
  • Evidence spot-check: All 117 repo:// evidence refs resolve to existing files with line ranges in bounds. Spot-verified key claims against source:
    • joinIPHub entry point and openHubConnection funnel (5 entry points) — confirmed in zeroHub.ts.
    • safeInvoke / guardCallback helpers (#189) — present in zeroHub.ts and peerSetup.ts.
    • wrapUpgradeError shared between websocket.go and migrate.go (#191) — confirmed, with dedicated test file.
    • build-harness.mjs parameterized script (#185) — builds both harness.js and unit-harness.js.
    • E2E spec count (8) and unit spec count (22) — verified against actual test/tests/ listing. unit-utils.spec.ts correctly absent (#190).
  • Prose accuracy: Updated claims about joinIPHub (previously documented as removed, now correctly reflects its re-addition in 28bd92f), SFU re-negotiation path, IP-hub routing, and build-harness consolidation are all consistent with the current source. "Static hubs" terminology used correctly for public-facing docs.
  • No stray files: CLAUDE.md and .github/workflows/openwiki-update.yml are absent as required.

Client formatting hunks (2 files):
The PR includes two small Prettier-canon collapses in client/src/zeroHub.ts (joinIPHub signature) and client/src/zeroHub.test.ts (test array entry). These fix a pre-existing formatting violation — the parent commit fails prettier --check, while the PR version passes. No behavioral change. Lint, format:check, and all 132 vitest tests pass on the PR branch.

Flagging as a minor scope note (Ponytail Rung 7) rather than a blocker: ideally these 11 lines would ride in a separate formatting commit, but reverting them would leave main failing its own npm run check.

CONVENTION: OpenWiki sync PRs should ideally touch only openwiki/ paths. If the builder's tooling incidentally reformats client files, the fix is acceptable only when the pre-existing code was non-Prettier-compliant and the change is mechanically generated (no semantic edits).

Ready for merge.

@ntsd
ntsd merged commit 965c8c4 into main Nov 21, 2026
1 check passed
@ntsd
ntsd deleted the task/zf-z-832a47cb branch November 21, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant