Repository navigation
[AI:zf-builder] docs(openwiki): sync architecture documentation for hotcode-dev-zerohub-share - #194
Conversation
…ub-share Task: zf-z-832a47cb
Deploying zerohub with
|
| Latest commit: |
76afbff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3990aa7f.zerohub.pages.dev |
| Branch Preview URL: | https://task-zf-z-832a47cb.zerohub.pages.dev |
ntsd
left a comment
There was a problem hiding this comment.
[AI:zf-reviewer] [Reviewer Feedback] Round 1: Approved for human review.
Docs sync — all verified clean.
Checks performed:
- JSON validity: All 8 files (6
.claims/*.json,.page-manifest.json,.last-update.json) parse cleanly. - pageVersion integrity: All 6 page SHA-256 hashes in
.page-manifest.jsonmatch the actual file content on disk. Claims filepageVersionvalues match the manifest entries. - Manifest gitHead:
add399a…== merge-base of this PR — correct. - Evidence spot-check: All 117
repo://evidence refs resolve to existing files with line ranges in bounds. Spot-verified key claims against source:joinIPHubentry point andopenHubConnectionfunnel (5 entry points) — confirmed inzeroHub.ts.safeInvoke/guardCallbackhelpers (#189) — present inzeroHub.tsandpeerSetup.ts.wrapUpgradeErrorshared betweenwebsocket.goandmigrate.go(#191) — confirmed, with dedicated test file.build-harness.mjsparameterized script (#185) — builds bothharness.jsandunit-harness.js.- E2E spec count (8) and unit spec count (22) — verified against actual
test/tests/listing.unit-utils.spec.tscorrectly absent (#190).
- Prose accuracy: Updated claims about
joinIPHub(previously documented as removed, now correctly reflects its re-addition in28bd92f), SFU re-negotiation path, IP-hub routing, and build-harness consolidation are all consistent with the current source. "Static hubs" terminology used correctly for public-facing docs. - No stray files:
CLAUDE.mdand.github/workflows/openwiki-update.ymlare absent as required.
Client formatting hunks (2 files):
The PR includes two small Prettier-canon collapses in client/src/zeroHub.ts (joinIPHub signature) and client/src/zeroHub.test.ts (test array entry). These fix a pre-existing formatting violation — the parent commit fails prettier --check, while the PR version passes. No behavioral change. Lint, format:check, and all 132 vitest tests pass on the PR branch.
Flagging as a minor scope note (Ponytail Rung 7) rather than a blocker: ideally these 11 lines would ride in a separate formatting commit, but reverting them would leave main failing its own npm run check.
CONVENTION: OpenWiki sync PRs should ideally touch only openwiki/ paths. If the builder's tooling incidentally reformats client files, the fix is acceptable only when the pre-existing code was non-Prettier-compliant and the change is mechanically generated (no semantic edits).
Ready for merge.
[AI:zf-builder] Task: zf-z-832a47cb
Automated PR for task zf-z-832a47cb
Completed by: @zf-builder