Repository navigation
Check this port against the compact-encoding corpus - #26
Merged
Merged
Conversation
A translation of the reference conformance.js, reading the corpus from an npm devDependency rather than vendored fixtures. The report follows the shape CONFORMANCE.md specifies, so two ports diff rather than get read side by side. First run: 166 matched, 8 diverged, 59 unrun across 17 codecs this port does not provide. The divergences confirm #18, #19 and #20, and turn up one case
kasperisager
requested changes
Nov 20, 2026
kasperisager
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
conformance.py, a translation of the corpus's referenceconformance.js, so this port can be checked againstcompact-encoding-testrather than only against its own tests.The corpus arrives as an npm devDependency, resolved rather than vendored, so a case added upstream arrives through the pin.
--jsonemits the report shapeCONFORMANCE.mdspecifies, so ports diff line by line.matched,divergedandunrunpartition all 233 cases. The cases of a codec this port does not export are unrun rather than passing, the one way a partial port reads as complete.The 8 divergences confirm #18, #19 and #20, and found
uint-uint64-top-byte, which #20 did not name. No fixes here - each is its own PR.Two notes for a reader of the diff. The corpus writes astral characters as UTF-16 surrogate pairs, so the notation goes through
utf-16-lewithsurrogatepass; building them per code unit yields lone surrogates and three false divergences. And a case's value is read outside the try that catches a refusal, so a harness bug raises rather than being reported as this port refusing.