Skip to content

Fix sum of two equals third - #26

Merged
vtm9 merged 2 commits into
hexlet-codebattle:mainfrom
dimaush:fix-sum_of_two_equals_third
Oct 16, 2026
Merged

vtm9 merged 2 commits into
hexlet-codebattle:mainfrom
dimaush:fix-sum_of_two_equals_third

Conversation

@dimaush

@dimaush dimaush commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

В тестах не было ни одного теста с отрицательными числами. Более того, эталонное решение выдавало бы на них неверные ответы. Исправил это недоразумение.

Также исправил то, что числа передаются не отдельно, а списком.

@vtm9 vtm9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking all three sums correctly fixes negative inputs, but the new asserts violate the published limits: [1000000000, 1000000000, 2000000000] and [-1000000000, -2000000000, -1000000000] contain values outside [-10^9, 10^9]. Keep the boundary cases within the stated limits, or update and audit the limits.

After merging with current main, base_score remains 100 while this PR reduces time_to_solve_sec to 60, contrary to the documented requirement that base score be lower than solving time. Please align the level, score, and path too: the file is under elementary but declares easy; this two-line implementation fits elementary.

All 37 submitted asserts pass; the remaining blockers are the published contract and metadata.

@vtm9
vtm9 merged commit 383e90f into hexlet-codebattle:main Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants