Repository navigation
Add new tasks - #14
Merged
Merged
Conversation
vtm9
requested changes
Oct 16, 2026
vtm9
left a comment
Contributor
There was a problem hiding this comment.
The new tasks are useful, but this PR is not ready to merge against current main.
- All 24 new task files omit required
base_score, so the currentmake check-limitscannot accept them. Add scores within the level limits and belowtime_to_solve_sec. game_of_life_stepandvalid_sudokuuse 600 seconds for medium tasks; the maximum is 450.peak_performance_sum,valid_sudoku, andminimum_bracket_reversalsalso need paths matchingtasks/<level>/<tags[0]>/<name>.toml.flood_fillfails on an allowed input:solution([[0] * 50 for _ in range(50)], 0, 0, 1)raisesRecursionErrorwith the default Python recursion limit. Use an iterative traversal and add this boundary case.
The 671 submitted asserts pass, but they do not cover this valid flood-fill boundary. Please address these blockers and run the current make build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.