Skip to content

Add new tasks - #14

Merged
vtm9 merged 4 commits into
hexlet-codebattle:mainfrom
aVitness:main
Oct 16, 2026
Merged

vtm9 merged 4 commits into
hexlet-codebattle:mainfrom
aVitness:main

Conversation

@aVitness

Copy link
Copy Markdown
Contributor

No description provided.

@vtm9 vtm9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tasks are useful, but this PR is not ready to merge against current main.

  1. All 24 new task files omit required base_score, so the current make check-limits cannot accept them. Add scores within the level limits and below time_to_solve_sec.
  2. game_of_life_step and valid_sudoku use 600 seconds for medium tasks; the maximum is 450. peak_performance_sum, valid_sudoku, and minimum_bracket_reversals also need paths matching tasks/<level>/<tags[0]>/<name>.toml.
  3. flood_fill fails on an allowed input: solution([[0] * 50 for _ in range(50)], 0, 0, 1) raises RecursionError with the default Python recursion limit. Use an iterative traversal and add this boundary case.

The 671 submitted asserts pass, but they do not cover this valid flood-fill boundary. Please address these blockers and run the current make build.

@vtm9
vtm9 merged commit 32bd512 into hexlet-codebattle:main Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants