[roodboi]

Fixes the cross-file state leaks tracked in HACK-1327. Only test infrastructure, test fixtures and contributor guidance change. No product code changes.

Root cause

bun test runs every file in one Bun process, so process.env, the working directory, the umask, process.exitCode, global functions and process listeners are shared by all files. When a test changed one of them and failed (or timed out) before its restore ran, every later file inherited the change. With PATH pointing at a fixture directory, later files failed with Executable not found in $PATH: git/bun (for example tests/projects-registry-admission.test.ts, tests/env-backend-command.test.ts). Those cascades hid the first, real failure.

Note: Bun.spawn without an env option uses Bun's own copy of the environment, taken at startup. Code that passes env: { ...process.env }, and node:child_process, use the live (leaked) PATH. That is why only some later files failed.

Sources found in this change:

• tests/native-compose-adoption-file-generation.test.ts: when the fixture lifetime was unknown, afterEach threw before restoring PATH, so PATH stayed on the fixture root (no git, no bun) for every later file.
• tests/helpers/retained-routing-adoption.ts (changed by test(adoption): give v14 compound routing operations the product's caller deadline #383) and its wrapper in tests/native-compose-adoption-routing-generation.test.ts: with an unknown lifetime, cleanup refused before restoring HACK_HOME, and the wrapper skipped cleanup, so HACK_HOME stayed on the fixture home.
• tests/helpers/retained-build-adoption.ts, tests/helpers/retained-source-bind-adoption.ts: PATH was changed before an awaited setup step; if that step threw, no fixture (and no cleanup) reached the caller.
• tests/helpers/native-compose-vm-files.ts: PATH, HOME, HACK_HOME and the Docker keys were deleted before the restore was registered, and one failing cleanup skipped the rest.
• tests/fzf.test.ts: replaced the process.env object with a plain copy, which detached it from Bun.env and reset unrelated keys.
• tests/native-config-protected-files-fixture.test.ts: the intentional-unknown negative left a pass-through process.kill spy installed for every later file.
• tests/e2e/harness.ts via tests/e2e-launchd-guard.test.ts: the launchctl shim registered a process exit listener for the whole Bun process (found by the guard on the M3 full run).
• Proxy keys that Bun keeps after a delete (found by the M3 full run of the first commit: 16 shared-host-lifecycle failures, helpers reported as foreign-listener or never ready). The engine-identity ambient-proxy test (tests/native-compose-engine-identity.test.ts) sets HTTP_PROXY, HTTPS_PROXY and their lower-case forms, then restores them with restoreEnv, which deleted them. Bun 1.4.2 copies assignments to the proxy keys (HTTP_PROXY, HTTPS_PROXY, NO_PROXY, lower-case too) into the environment that fetch and Bun.spawn without env use, but a delete never reaches that copy, and after a delete Bun ignores later assignments to that key too. So every later fetch in the process, loopback included, went through a dead proxy while process.env looked clean. Bisected on this Mac: engine-identity + shared-host-lifecycle alone gave 67 pass / 16 fail, with or without the guard preload. Full runs on next passed only because tests/fzf.test.ts runs earlier and left process.env as a plain copy, which Bun no longer reads: after it, proxy assignments never reached fetch at all (checked with a standalone script). So the fzf fix above exposed this leak, and on next the engine-identity ambient-proxy case has not really exercised a proxy in full runs.

Fix

• New guard, preloaded from bunfig.toml: tests/helpers/global-state-guard-preload.ts with the logic in tests/helpers/global-state-guard.ts.
  • It snapshots the full environment (and the process.env object identity), cwd, umask, process.exitCode, guarded globals (fetch, timers, Date, Bun.spawn, Bun.spawnSync, Bun.which, process.exit, process.kill, process.platform) and the listeners of signal/exit/error process events.
  • Per test: the preload beforeEach runs before a file's own hooks and the preload afterEach after them, so a correct beforeEach/afterEach pair passes. A mismatch fails that test with a message naming the file.
  • Per file: a runtime plugin onLoad for test files is the file boundary (it runs after the previous file's afterAll and before the next file's module code; it returns the source unchanged). A mismatch is reported at once, naming the previous file, and the preload afterAll fails the run with every leaking file. This catches module-scope and beforeAll/afterAll leaks.
  • Per file it also compares Bun's native environment (one short /usr/bin/env -0 child per file, about 3 ms) and reports native env <KEY> changed for a proxy key that process.env no longer shows.
  • On a mismatch it restores the environment (in place, on the original object), cwd, umask and exit code, so later files run clean. Bun cannot take a deleted proxy key back, so for a native mismatch the guard sets NO_PROXY=* in Bun's native environment (and leaves process.env unchanged): later fetches go direct.
  • Replaced functions and listeners are reported but not restored. A leak there usually comes from a timed-out test whose work is still running, and the fake is what keeps that work away from real processes, signals, the network and the Docker socket.
  • Messages name keys and kinds only (env PATH changed, cwd changed, native env HTTP_PROXY changed), never values.
  • The env allowlist is empty; no exception was needed.
• Leak fixes for every source listed above. The fixtures keep their roots and spies when a lifetime is unknown, but never keep the environment. This matches test(native): isolate startup settlement guard per case #388 (HACK-1299).
  • restoreEnv (tests/helpers/env.ts) assigns "" before deleting a key, so a proxy key ends empty (no proxy) in Bun's copy instead of keeping the test's value. This fixes the engine-identity source and every other restoreEnv caller.
  • releaseLaunchctlGuard() in the e2e harness removes the shim and its exit listener; e2e-launchd-guard.test.ts calls it after each test. The e2e runner still keeps one shim per process.
• .ai/skills/hack-repo-verify/SKILL.md: explains the guard, says to fix the named file, and to restore env keys with restoreEnv.
• Merged the current next (616407a5); no conflicts.

Tests

• tests/global-state-guard.test.ts:
  • The diff names added, changed and removed keys and a cwd change, without values; the native diff names keys only and treats empty as unset.
  • Restore puts back keys, the env object, cwd and exit code.
  • Replaced functions and listeners are reported but kept.
  • Two nested bun test runs in a temp dir (stub executable on a temp PATH, temp HOME/TMPDIR, no proxy) compare a suite without the guard and with it. Without the guard, a file that sets PATH and throws makes a later file fail with Executable not found in $PATH, and a file that sets HTTP_PROXY and deletes it makes a later loopback fetch fail. With the guard, the run names a-leak-in-test.test.ts (per test), b-leak-in-hooks.test.ts (per file, beforeAll without restore) and c-leak-native-proxy.test.ts (native env HTTP_PROXY changed), and both later checks pass.
  • A child-process probe shows restoreEnv leaves no proxy in Bun's native environment, while a bare delete does (it fails if a Bun upgrade fixes the delete, so the workaround can go).
• tests/native-compose-adoption-routing-generation.test.ts: a refused teardown still restores HACK_HOME.
• tests/e2e-launchd-guard.test.ts: releasing the launchctl guard removes its shim and exit listener.

Mutation proofs (each applied and reverted)

Mutation	Result
Preload never restores	nested "later files pass" case fails
Diff ignores env keys	diff case and nested case fail
Env object not reinstated	restore case fails
cwd not restored	restore case fails
Bindings not reported	function/listener case fails
Bindings restored too	function/listener case fails
File-boundary check removed	nested case fails
Native env check removed	nested case fails (no native env message; later loopback fetch refused)
disableNativeProxies is a no-op	nested case fails (later loopback fetch refused)
restoreEnv deletes without the "" assignment	guard names native-compose-engine-identity.test.ts (native env HTTP_PROXY/HTTPS_PROXY/http_proxy/https_proxy changed); with the guard's repair shared-host-lifecycle still passes 83/83
releaseLaunchctlGuard keeps the exit listener	guard fails each e2e-launchd-guard test with process 'exit' listeners changed; the new release case fails
Routing cleanup restores HACK_HOME only after the lifetime check	refused-teardown case fails
releaseEnvironment is a no-op	refused-teardown case fails
Old fzf process.env = {...}	guard fails 9 fzf cases with "process.env object replaced"

The required injection (3) is kept as the nested regression tests above, so no injected test file remains in the tree.

Evidence

• Bun 1.4.2 (mise x bun@1.4.2).
• Local (macOS, this Mac) at the pushed head: bun run --cwd packages/cli typecheck 0 errors; root bun run check passes (privacy-check ok; only existing warnings, none in changed files); gitleaks 8.30.1 over origin/next..HEAD: no leaks.
• Local focused runs at the pushed head: guard, launchd-guard, fzf, cli-spawn-env-isolation, e2e-scenario-selection, protected-files fixture: 73/73. native-compose-engine-identity + shared-host-lifecycle: 83/83 (before the fix: 67 pass, 16 fail). Routing-generation + file-generation: 47/47.
• M3 full suite at the first commit (58ed88dd): 7,691 pass, 21 fail. The guard named tests/e2e-launchd-guard.test.ts (exit listener; fixed). 16 shared-host-lifecycle failures (proxy root cause above; fixed). 1 repository catalog failure and 2 new no-host failures also fail in every other M3 full run on next (unrelated; see findings).
• Hosted CI at 8b207083: all 16 checks pass, including test and the four docker-e2e shards.
• M3 full suite at the pushed head: queued, not yet run. The shared M3 lock is held by the disk guard because / has 57 GiB free (floor 58 GiB). This PR will be updated with the result.

Gaps

• The guard restores the baseline environment under a timed-out test's unsettled work. If that work later spawns docker or resolves HACK_HOME, it sees the real PATH and (when unset) the default ~/.hack. Before this change it kept the fixture values and broke later files instead. The suite has no run-wide sandbox for HACK_HOME, DOCKER_HOST or DOCKER_CONFIG.
• After a native proxy leak, children spawned without env still inherit the stale proxy key (next to NO_PROXY=*). The run fails anyway and names the file.
• mock.module and spyOn on module exports (and on Date.now) are process-global in Bun and are not tracked: the guard cannot see them. The retained-routing fixture deliberately keeps its module spies when its lifetime is unknown.
• The file-boundary check depends on Bun calling a runtime plugin onLoad for each test file in order (verified on Bun 1.4.2). With --parallel, each worker gets its own preload. The native check needs /usr/bin/env; without it, it is skipped.

Round G68 (HACK-1392): SIGINT listener leak found by the guard on next + this PR

Merge gate b48 (#445) failed twice on next + this PR with four deterministic failures, reproduced locally in the same order (bun test tests/loki-short-lived-logs.test.ts tests/native-authored-project-oneoff.test.ts tests/global-state-guard.test.ts): the two Loki follow ... tests from #417, public cancellation after run completion returns130 without rendering or replay, and the guard's (unnamed) file summary, each with process 'SIGINT' listeners changed.

Root cause

One product leak, blamed on two files:

• src/ui/loki-logs.ts lokiTail registered process.once("SIGINT", () => stop()) and never removed it. A follow that ends because the socket closes (the normal path, and what both fix(logs): escape Loki selectors once, quiet Alloy info logs and add empty-follow hints #417 tests do) left that once handler in the process. Each follow test added one more.
• tests/native-authored-project-oneoff.test.ts runs after the Loki file and its cancellation test calls process.emit("SIGINT"). That fired the two stale Loki handlers, which removed themselves, so the SIGINT listener list changed (2 -> 0) during the one-off test and the guard named that test and file. runAuthoredCommand in src/lib/native-authored-command.ts (the process.on/process.off pair around line 920-965) is symmetric on every path; the other two registrations in that file (logs, line 98-141, and the startup wrapper, line 649-668) are too. The one-off file passes on its own with the guard active (50/50), and passes after the Loki fix when run after the Loki file.

Fix

• src/ui/loki-logs.ts: the SIGINT handler is a named function installed right before the tail awaits its close and removed in a finally, so a socket close, an error close and a SIGINT (where the once handler already removed itself and off is a no-op) all leave the listener list as it was. Everything between new WebSocket and that await is synchronous, so the registration point has no observable change.
• tests/helpers/global-state-guard.ts: the listener message now carries counts, process 'SIGINT' listeners changed (2 -> 0), so a handler consumed by the named test (an earlier file's leak) reads differently from one it added (0 -> 1). Counts only, no values. No allowlist, skip or special case was added; the guard's own tests stay green.

Tests

• tests/loki-short-lived-logs.test.ts:
  • Loki follow removes its SIGINT listener once the tail closes: one listener while the tail is open, the same list as before once the socket closes.
  • Loki follow stops on SIGINT and leaves no listener behind: the follow's own handler (called directly rather than process.emit, which would reach every listener in the shared test process) closes the tail with exit 0 and the list is back to the baseline.
• tests/global-state-guard.test.ts: the listener change line includes the counts.

Mutation proofs (applied and reverted): with the lokiTail fix reverted, both new tests fail on their own expect (and the guard names the file, 0 -> 1, 1 -> 2, ...); with the count change reverted, the guard test fails (Expected to contain: "process 'SIGUSR2' listeners changed (0 -> 1)").

Evidence

• Bun 1.4.2 (mise x bun@1.4.2), this Mac, at 9870275f: the three files above 77/77 with the preload active (before: 72 pass, 4 fail); tests/log-backend.test.ts 5/5; bun run --cwd packages/cli typecheck 0 errors; root bun run check passes (privacy-check ok, 34 existing warnings, none in changed files); ultracite check on the four changed files clean; gitleaks 8.30.1 (gitleaks dir over a git log -p origin/next..HEAD export): no leaks.
• Merged the current next (a74eedbc); no conflicts.
• Hosted CI at 9870275f: see the PR checks.
• M3 full suite at 9870275f: queued behind other units on the shared M3 lock; this PR will be updated with the result.

Gaps

• A test that calls process.emit("SIGINT") still reaches every SIGINT listener in the shared process, so another file's leaked handler would again be charged to that test; the counts in the guard message now make that readable, and the guard already names the leaking file at its own boundary.
• No CLI surface, agent guidance, or pinned toolchain file changed.

Refs HACK-1327, HACK-1392

🤖 Generated with Claude Code

[linear-code]

HACK-1327

HACK-1392