Skip to content

fix(deps): use javax.jdo:jdo2-api 2.3-eb, which has a license in its POM - #2635

Closed
hj690 wants to merge 1 commit into
mainfrom
fix-jdo2-api-license
Closed

hj690 wants to merge 1 commit into
mainfrom
fix-jdo2-api-license

Conversation

@hj690

@hj690 hj690 commented Oct 14, 2026 •

Copy link
Copy Markdown

Context

MOSS requires that our builds use Airlock. The goal is to pull all third-party dependencies only from Airlock, which is the trusted source. This PR fixes the same blocker that b/573257533 reports for google-oauth-java-client.

Problem

  • The parent pom.xml manages javax.jdo:jdo2-api:2.3-20090302111651 in dependencyManagement. No module declares jdo2-api today. But dependency scans can still see the managed version, and any module that adds jdo2-api gets this version.
  • Airlock does not validate this version because of a license issue. MOSS reports "NO VALID LICENSE", because the published POM has no <licenses> block.
  • This version came from Renovate in chore(deps): update dependency javax.jdo:jdo2-api to v2.3-20090302111651 #1952.
  • The Renovate change was not a real upgrade. Maven ranks a numeric qualifier above a text qualifier, so 20090302111651 sorts after eb. But the 20090302111651 jar is older. Its manifest dates it to 2008-12-28 and says Implementation-Version: 2.3-SNAPSHOT. The 2.3-eb jar dates from January 2010.

Fix

This PR replaces the dependency with javax.jdo:jdo2-api:2.3-eb. Airlock validates this version (it is in maven-3p-trusted), and its POM declares Apache 2.0.

Testing and verification

Why I think this change is safe:

  • No module in this repo uses jdo2-api, so the change does not affect any published module.
  • The Java package (javax.jdo) and the artifactId do not change.
  • googleapis/google-oauth-java-client makes the same change. In that repo, the JDO classes build and pass tests with 2.3-eb, and the enhanced bytecode is byte-identical.

Tests I did:

  • mvn validate passes.
  • The effective parent POM manages jdo2-api at 2.3-eb.

@hj690
hj690 requested a review from a team as a code owner October 14, 2026 21:00
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Oct 14, 2026
@hj690

hj690 commented Oct 15, 2026

Copy link
Copy Markdown
Author

This is prob not necessary as I revisit, closing for now.

@hj690 hj690 closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant