Look up Kotlin PropertyMetadata by property name instead of field signature. - #5301
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…nature. Previously, `KotlinMetadata` matched fields to their Kotlin property metadata using the field's JVM descriptor, with a fallback that stripped the `$delegate` suffix from the field name when KAPT failed to resolve generated types in the descriptor (https://youtrack.jetbrains.com/issue/KT-35124). Because a Kotlin class cannot have multiple properties with the same name and `XFieldElement.getOwner()` provides the owning `XPropertyElement` directly, we can look up properties by name instead. This simplifies the lookup, avoids descriptor mismatches on generated types, and prepares `KotlinMetadata` to take `XPropertyElement` directly in a follow-up change. RELNOTES=N/A PiperOrigin-RevId: 989258318
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look up Kotlin PropertyMetadata by property name instead of field signature.
Previously,
KotlinMetadatamatched fields to their Kotlin property metadata using the field's JVM descriptor, with a fallback that stripped the$delegatesuffix from the field name when KAPT failed to resolve generated types in the descriptor (https://youtrack.jetbrains.com/issue/KT-35124).Because a Kotlin class cannot have multiple properties with the same name and
XFieldElement.getOwner()provides the owningXPropertyElementdirectly, we can look up properties by name instead. This simplifies the lookup, avoids descriptor mismatches on generated types, and preparesKotlinMetadatato takeXPropertyElementdirectly in a follow-up change.RELNOTES=N/A