fix(domain): surface premium domain fees in available/suggest/quote

[jpage-godaddy]

Summary

• domain available/domain suggest parsed pricing but never read the API's inventory/fees fields, so a premium domain's one-time acquisition surcharge (e.g. an Afternic fast-transfer domain) was invisible until quote time.
• domain quote already computed inventory/fees correctly, but they were missing from default_fields — which cli-engine projects every default output (human table and default --output json alike) down to. Same masking bug previously fixed for renewalPrice (GDDEVPLAT-133). Even a genuine premium quote showed only the base registration price, silently omitting a surcharge that can run into the thousands of dollars.
• Shares the existing fees_to_json helper (moved from quote into domain::common) across all three commands.
• (Refined during review) domain suggest's human table had no columns for fees1Year/fees2Year either — added, so the surcharge is visible there too, not just in --output json. Also corrected the inventory field's schema comment across all three commands: it's present whenever the API returns an inventory source at all (REGISTRY/REGISTRY_PREMIUM/PREMIUM), not only for premium domains.

Test plan

• cargo check --workspace
• cargo clippy --workspace -- -D warnings
• cargo test --workspace (976 passed)
• cargo fmt --check
• ./rust/scripts/check-module-size.sh
• Verified live against a real premium domain (bingoboard.com): before the fix, gddy domain quote/domain available showed only the $22.99 base price; after the fix, both surface the $3,500.00 ONE_TIME_PREMIUM_DOMAIN_PURCHASE fee and inventory: PREMIUM, in both human and JSON output.

🤖 Generated with Claude Code

[Copilot]

Copilot review overview

🟡 Changes recommended

domain suggest does not render the new fee fields in its human-readable table.

Review effort: Lite
Findings: 1

Open (1)

• Add table columns for one-year and two-year fee fields · New

What changed in this PR

This PR surfaces premium-domain inventory and acquisition fees across domain availability, suggestions, and quotes.

Changes:

• Shares fee serialization through domain::common.
• Adds inventory and term fees to command outputs and default fields.
• Adds regression coverage for fee formatting and projections.

File	Summary
rust/​src/​domain/​common.rs	Shared fee serialization helper.
rust/​src/​domain/​available.rs	Exposes premium inventory and term fees.
rust/​src/​domain/​suggest.rs	Exposes premium inventory and per-term fees; human table columns remain incomplete.
rust/​src/​domain/​quote.rs	Includes inventory and fees in default output.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[kperkins-godaddy]

We can tidy this up more tomorrow.

[Copilot]

Copilot review overview

🟢 Approval recommended

No blocking issues were identified; remaining findings are minor documentation nits.

Review effort: Lite
Findings: None

Resolved since last review (1)

• Add table columns for one-year and two-year fee fields

Previously missed (2)

In code that hasn't changed since last review

Document all possible inventory values

rust/​src/​domain/​available.rs:30

This description is narrower than the value emitted by the handler and the API contract: body.inventory is copied for every returned inventory type, including ordinary REGISTRY (and REGISTRY_PREMIUM), not only premium domains. Since this comment is exposed as output/schema guidance, please describe the three possible inventory values accurately.

Clarify inventory is not premium-only

rust/​src/​domain/​suggest.rs:33

This says inventory is only present for premium suggestions, but suggestion_to_json emits any API inventory value and the API includes ordinary REGISTRY suggestions. The schema/help comment should match the actual output rather than implying this field is absent for standard domains.

[jpage-godaddy]

Fixed in 859a8e4: addressed the two "Previously missed" findings from Copilot's review body (no separate resolvable thread existed for these):

• available.rs/suggest.rs/quote.rs: corrected the inventory field's schema comment — it's present whenever the API returns an inventory source at all (REGISTRY, REGISTRY_PREMIUM, or PREMIUM), not only for premium domains. Only the latter two carry a surcharge, in fees. Fixed quote.rs's pre-existing comment too, for consistency, since it had the same inaccuracy and I was already touching the file.

[Copilot]

Copilot review overview

🟢 Approval recommended

All reviewed changes are covered and no unresolved blocking issues remain.

Review effort: Lite
Findings: None