Take the jpeg2000 release that stops copying a whole-component tile - #94
Merged
Merged
Conversation
v0.10.1 hands a tile's coefficients to the component plane instead of copying every row onto a buffer of the same shape. Decoding one 5868x7885 one-component scan alone, peak RSS falls 917 -> 751 MB and the live heap 717 -> 540 MB. Nothing here changes: the 3215 documents of the measured corpus that render byte-identically were rendered by exactly this pair, v0.61.0 against v0.10.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-images/jpeg2000v0.10.1 hands a whole-component tile's coefficients to thecomponent plane instead of copying every row onto a buffer of the same shape —
what
opj_j2k_move_data_from_codec_to_output_imagedoes in the reference.Decoding one 5868×7885 one-component scan alone, so the figures are the
decoder's:
Nothing in this repository changes. The 3215 documents of the measured corpus
that render byte-identically (0 different, 66 drawn by neither, population
floor 3000) were rendered by exactly this pair — v0.61.0 against v0.10.1 — and
the module in the cache was diffed against the tree that was proved.
🤖 Generated with Claude Code