Annotations ARE implemented here, and three absences are somewhere else - #35
Merged
Merged
Conversation
"Encryption, tagged/PDF-A, forms and annotations are not yet implemented" is
one line denying four things. Measured in this repository and the organisation:
annotations page.go:83 AddLink, :90 AddNamedDest, :97 AddNamedLink write a
clickable /Link. The sentence is simply false.
encryption absent here (0 non-test files), present in go-pdfkit/reader:
RC4-40 through AES-256 read, AES-128 and AES-256 written.
forms absent here (no AcroForm), present in go-pdfkit/forms and xfa.
tagged/PDF-A PDF/A absent everywhere; a structure tree is preserved by
go-pdfkit/ops and created by nothing.
"Not implemented" and "not in this package" are different sentences, and the
reader who needs the second is sent away by the first. Each bullet now says
which one it means and where the answer is.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line denying four things. Measured in this repository and across the
organisation:
page.go:83AddLink,:90AddNamedDest,:97AddNamedLinkwrite a clickable/Link. The sentence is simply false.go-pdfkit/reader: RC4-40 through AES-256 read, AES-128 and AES-256 writtenAcroForm), present ingo-pdfkit/forms, andxfareads the other kindgo-pdfkit/opsand created by nothing"Not implemented" and "not in this package" are different sentences, and the
reader who needs the second is sent away by the first. Each bullet now says which
one it means, and where the answer is.
Companion pull requests:
go-pdfkit/.github#19(the same claim on the profile)and
go-pdfkit/go-pdfkit.github.io#12(the five modules the site never named).🤖 Generated with Claude Code