fix(deps): update module github.com/go-opentype/opentype to v0.13.0 - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.12.0→v0.13.0Release Notes
go-opentype/opentype (github.com/go-opentype/opentype)
v0.13.0: — a ceiling that a 32-bit int walked throughCompare Source
Judge a table's extent in int64
The table-directory reader refused an out-of-range table by adding two uint32s
converted with
int():intis 32 bits on a 32-bit build, so a length of0xFFFFFFFFbecomes −1.off+lengththen comes out smaller thanoff, the check passes a table thatis not in the file, and the slice that follows panics —
b[184:183]— in areader whose whole purpose is to refuse a malformed font rather than crash on one.
TestParseErrors/table_out_of_rangealready covered this and was alreadycorrect. It had simply never been run on a machine where an
intis 32 bits.New: the tests run on six architectures
riscv64,loong64,ppc64le,s390x(big-endian),386andarm(32-bitint) — underqemu-user-static, except386, which runs natively becauseqemu-i386loses the guest's floating-point state across the signal Go deliversfor asynchronous preemption (5 failures in 8 identical lanes emulated, 0 in 8
native).
The CI previously cross-compiled for the 64-bit four and ran on none of them.
Every big-endian lane was green from the first run — a font file is a big-endian
container, so the readers had nothing to unlearn. Both 32-bit lanes failed, and
the fix above is what they found.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.