Repository navigation
fix(table): ignore cells past the delimiter column count - #178
Merged
Merged
Conversation
A row with more cells than the delimiter row defines produced a layout whose cells outnumbered col_widths, so painting indexed col_widths[ci] out of bounds and panicked with "index out of bounds" on startup. Closes #176
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the startup crash reported in #176.
A table row with more cells than the delimiter row defines produced a
CanvasLayoutwhose per-rowcellsoutnumberedcol_widths. Paintingthen indexed
col_widths[ci]out of bounds and panicked withindex out of bounds: the len is 4 but the index is 4.The layout now ignores cells past the delimiter column count, matching
GFM where the delimiter row defines the number of columns. The source
text is untouched: only the painted canvas drops the excess cells.
Adds a regression test that feeds a 5-cell row under a 4-column
delimiter and asserts no row outnumbers the columns.
Closes #176