Repository navigation
fix(ui): choose the OpenCloud space when adding a folder - #328
Merged
Merged
Conversation
Received shares are LibreGraph drives of type mountpoint, named after the original resource and browsable at /dav/spaces/<id>/. Keep them in the space listing (the virtual Shares aggregate stays out) and add a helper to read the top-level folders of one space.
The Add Folder dialog listed remote folders from the Nextcloud dav/files tree, which on OpenCloud exposes the aggregate Shares jail, so a recipient of a share only saw 'shares'. Both the dialog and the setup wizard now list the account's spaces (personal, projects and received shares by their original name), read the remote folder picker from the chosen space and store its id on the folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Received shares are their own LibreGraph drive (
driveType: mountpoint), named after the original resource and browsable at/dav/spaces/<id>/.list_opencloud_spacesdropped them, so the only remaining path for the picker was the Nextclouddav/filestree, which on OpenCloud exposes the aggregateSharesjail. A recipient of a share ended up seeingsharesinstead of the shared folder name, and nothing to synchronize.Measured on a real OpenCloud 9 deployment with a temporary share between two users:
GET /graph/v1.0/drivesreturnspersonal,virtual(Shares) andmountpoint(publico, the received share).PROPFIND /remote.php/dav/spaces/<mountpoint id>/answers 207.PROPFIND /remote.php/dav/files/<recipient>/listsShares/, which is what the dialog used to show.Changes:
mountpointdrives in the space listing (thevirtualaggregate stays out) and carry the kind, so pickers can prefer the account's personal space.list_opencloud_space_foldersreads the top-level folders of one space over WebDAV.Gates: 783 tests (0 failed, 3 ignored),
cargo clippy --all-targets -- -D warnings,cargo fmt --check, translation catalog regenerated (541 entries).Closes #327