Conversation
hannesa2
force-pushed
the
TestInci
branch
2 times, most recently
from
September 19, 2026 06:47
d9d5447 to
733c46d
Compare
This was referenced Sep 29, 2026
Collaborator
|
I tested this PR locally on top of #113 (the
Your SHA-1 signing fix works as intended: Debug builds sign cleanly with no flag overrides. Once #113 is merged, could you rebase this onto master? After that, the 4 failures above are all that's left before CI goes green. We can split them up between us if you like. On the unzip race commit from #111 ( |
hannesa2
force-pushed
the
TestInci
branch
2 times, most recently
from
September 30, 2026 05:17
11bc5ce to
965e971
Compare
The vendored Carthage/Checkouts/xcconfigs Base/Configurations/Debug.xcconfig
hardcodes OTHER_CODE_SIGN_FLAGS = --digest-algorithm=sha1 --timestamp=none
for every Debug build. Current codesign refuses SHA-1 outright:
error: signing with only SHA1 not allowed. Please remove `sha1`
from the `--digest-algorithm` code signing flag.
which was breaking ObjectiveGit-MacTests' CodeSign build phase (and
would break the ObjectiveGit-Mac framework and ObjectiveGit-iOS
target the same way, since they share the same project-level Debug
config).
Since Base/Configurations/Debug.xcconfig lives in a separate vendored
git submodule (jspahrsummers/xcconfigs) fetched fresh by
script/bootstrap on every CI run, patching it directly wouldn't
survive a bootstrap. Instead, override OTHER_CODE_SIGN_FLAGS directly
in the project's own Debug build configuration, which takes
precedence over the same key supplied by baseConfigurationReference.
Keeps --timestamp=none (skips the network-dependent Developer ID
timestamp server, still fine for local/CI ad-hoc signing) and just
drops the now-rejected --digest-algorithm=sha1.
Author
|
Now it uploads the test result on failure and these are the remaining issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.