Skip to content

Fix the test fixtures failing to unzip #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goneng wants to merge 2 commits into from
Closed

Fix the test fixtures failing to unzip #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1580985
Remove the escaping symlinks from the test fixtures
goneng Sep 29, 2026
8545fdd
Stop caching a fixture directory that failed to unzip
goneng Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ObjectiveGitTests/QuickSpec+GTFixtures.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ - (void)setUpRepositoryFixtureIfNeeded:(NSString *)repositoryName {
error = nil;
success = [self unzipFromArchiveAtPath:zippedRepositoriesPath intoDirectory:cleanRepositoryPath error:&error];
XCTAssertTrue(success, @"Couldn't unzip fixture \"%@\" from %@ to %@: %@", repositoryName, zippedRepositoriesPath, cleanRepositoryPath, error);
if (!success) {
[NSFileManager.defaultManager removeItemAtPath:cleanRepositoryPath error:NULL];
return;
}
}

success = [[NSFileManager defaultManager] copyItemAtPath:[cleanRepositoryPath stringByAppendingPathComponent:repositoryName] toPath:path error:&error];
Expand Down
Binary file modified ObjectiveGitTests/fixtures/fixtures.zip
View file
Open in desktop
Binary file not shown.
Loading