Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Downstream stream cleanup must be fixed to prevent leaks.
Review effort: Lite
Findings: 1
What changed in this PR
Migrates GTFilter from libgit2’s deprecated apply callback to the streaming filter API.
Changes:
- Buffers stream input and applies the Objective-C block on close.
- Forwards transformed output downstream.
- Adds stream lifecycle management.
| File | Summary |
|---|---|
ObjectiveGit/GTFilter.m |
Implements the streaming filter adapter. The downstream stream is not freed during cleanup, causing a leak; release it before freeing the wrapper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hannesa2
force-pushed
the
fix/GTFilter-migrate-to-streaming-api
branch
from
September 28, 2026 05:33
8da78d6 to
3aa60d3
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>
libgit2's own pipeline (filter_streams_free in filter.c) already frees every writestream in the chain exactly once, including next. Its own buffered_stream_free wrapper (used by the built-in crlf/ident filters) deliberately does not free its target/next stream for this reason. Freeing next here as well causes a double free.
hannesa2
force-pushed
the
fix/GTFilter-migrate-to-streaming-api
branch
from
September 28, 2026 06:49
0dc3d46 to
fe05cc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the last remaining
import "git2/deprecated.h"