Repository navigation
feat(cli): Decode iOS asset catalogs with CoreUI - #1500
Conversation
Port the pinned legacy Swift reader, preserve its manifest and image pairing, and embed the decoder in macOS arm64 binaries. Add safe deterministic normalization, real catalog fixtures, and native integration coverage. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Merge current main, remove redundant license disclosures, require native asset-catalog checks in the aggregate test gate, and preserve universal idiom metadata with regressions. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e24253e. Configure here.
Keep the phone-specific legacy catalog and compile a separate universal image set with actool. Verify both idioms through XCArchive, IPA, and embedded-binary uploads. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
|
Reviewed the final Warden helper-path annotation against the exact-head macOS run. It repeats the earlier lookup finding: SwiftPM provides the release alias, and all eight native cases passed on 79f76b3, including source-mode XCArchive/IPA normalization and universal-image upload through the embedded binary. The remaining annotation is a false positive; no code change is needed. Native evidence: https://github.com/getsentry/toolkit/actions/runs/38667923127/job/116204089698 |

Summary
Supersedes getsentry/cli#1469 and carries its iOS asset-catalog work into Toolkit.
Closes getsentry/cli#1429.
getsentry/sentry-cli@c596fcddd616867b6c6cdfa11f9853dc889a585a.Assets.jsonarray, metadata fields, and sibling<imageId>.<extension>image association. Canonicalize IDs and rename their images together for deterministic uploads.These changes address Trevor's five review points on the original PR: native path resolution, the complete reader, the manifest contract, image filenames, and using CoreUI instead of reverse-engineering the catalog format.
Validation
Validated on Toolkit base
098a9b23:pnpm run tsc— passed.pnpm run lint— passed.pnpm run test --printConsoleTrace— passed across all workspaces:git diff --check— passed.Native CoreUI execution is covered by the macOS arm64 job, which now feeds the required aggregate
testgate.Review update (
e24253e7)1b63965fand reran typecheck, lint, all workspace tests, documentation/generated-file checks, CLI policies, and all 65 CI-policy tests successfully. The CLI suite passed 10,795 tests; the Local viewer passed 110.Fixture correction (
79f76b3f)The legacy catalog is phone-specific. The native suite now compiles a separate explicitly universal image set with Xcode actool and tests both idioms through XCArchive, IPA, and embedded-binary uploads: eight native cases. Both original real catalogs and all pixel, filename-association, and repeat-upload checks are retained.
Local typecheck, lint, workspace tests, documentation/generated-file checks, and all 65 CI-policy tests passed. macOS CI passed all eight native cases on
79f76b3f, including universal assets uploaded through the embedded binary: https://github.com/getsentry/toolkit/actions/runs/38667923127/job/116204089698 .