Skip to content

ref(pymongo): Drop send_default_pii support - #7714

Open
pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/pymongo-drop-pii
Open

pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/pymongo-drop-pii

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

  • drop send_default_pii support for Pymongo integration.

Issues

Resolves #7605

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 62577 passed | ❌ 13 failed | ⏭️ 2890 skipped | Total: 65480 | Pass Rate: 95.57% | Execution Time: 178m 6s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -72226
Passed Tests 📉 -68007
Failed Tests 📈 +13
Skipped Tests 📉 -4232

➕ New Tests (13)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing
  • test_sets_new_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_uses_existing_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_sets_endpoint
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_none_falls_back_to_dsn
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_sets_new_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_uses_existing_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_sets_endpoint
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_none_falls_back_to_dsn
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_sets_new_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_uses_existing_tracer_provider_with_otlp_exporter
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_sets_endpoint
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing
  • test_collector_url_none_falls_back_to_dsn
    • File: tests.integrations.otlp.test_otlp
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140441995936192

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140441995936192

test_sets_new_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_uses_existing_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_sets_endpoint

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_none_falls_back_to_dsn

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_sets_new_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_uses_existing_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_sets_endpoint

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_none_falls_back_to_dsn

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_sets_new_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_uses_existing_tracer_provider_with_otlp_exporter

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_sets_endpoint

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

test_collector_url_none_falls_back_to_dsn

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace
tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

✅ Patch coverage is 100.00%. Project has 2066 uncovered lines.
❌ Project coverage is 90.16%. Comparing base (979c7d4) to head (0a5ee58).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.20%    90.16%    -0.04%
==========================================
  Files          194       178       -16
  Lines        26030     20994     -5036
  Branches      9678      7570     -2108
==========================================
+ Hits         23480     18928     -4552
- Misses        2550      2066      -484
- Partials      1454      1196      -258

Generated by Codecov Action

@pabloDeputter
pabloDeputter marked this pull request as ready for review September 25, 2026 13:43
@pabloDeputter
pabloDeputter requested a review from a team as a code owner September 25, 2026 13:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant