Repository navigation
Conversation
This was referenced Oct 17, 2026
Collaborator
|
Hi, thanks for the proposal. With a flat The project generally uses Also, could we keep it focused on the minimal CMake fixes needed to run the existing unit tests through CTest? A dedicated integration suite for the CTest wiring is unnecessarily heavy for this scope. 🙂 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CTest's default build does not place the unit executable next to the backend helper it discovers at runtime. Building only
sentry_test_unitalso does not build that helper. Once the helper is supplied manually, individual CTest cases still race over the same filesystem fixtures underctest --parallel.Preserve CMake's emulator/launcher prefixes and CMP0158 behavior. Add regression coverage for default output paths with spaces, both helper targets, parallel execution, aggregate mode, command prefixes, and repeated success/failure fixture handling. This follows the individual CTest registration introduced in #1244; it changes test setup only.
Evidence
Tested against master
bbbd78cd714e282c900d1d19aa75da6b93962e98(SDK 0.17.4), with initialized recursive submodules.sentry/basic_function_transport(zero transport calls rather than two). Building/copying the handler manually still leaves six failing cases in a parallel CTest run:cache_max_size,crashed_last_run,installation_id,multiple_inits,old_run_retry, andon_crashed_last_run.CMAKE_BUILD_PARALLEL_LEVEL=8 CTEST_PARALLEL_LEVEL=8 pytest -q tests/test_ctest.py), including prefix arguments containing spaces and fresh-directory success/failure behavior.make formatandmake stylepass with the pinned formatter requirements. Valgrind reports zero errors forpath_basics,path_directory, andpath_remove_all_symlink, invoked through the forwarded CTest launcher with full leak checking and definite leaks treated as errors.Linux native-backend validation exposes an independent existing failure in
minidump_structures_packed: the x86-64 context-size assertion attest_native_backend.c:766. This PR does not change the structure or assertion. The same assertion fails in a freshly built, unmodified upstream baseline. Ninja Multi-Config Debug and RelWithDebInfo each pass the other 613/614 registrations; this assertion is the only failure in both. The native regression parameter focuses on helper discovery and shared filesystem cases;noneandcrashpadexercise the complete CTest set and aggregate mode.Follow-up: the independent minidump assertion is corrected separately in #2216. Its test arithmetic expected 1244 bytes for the correct 1232-byte AMD64 structure. A disposable combined-source build of both patches passes all 614 Linux native CTest registrations in parallel and with two consecutive repetitions. This PR remains focused on CTest setup.
Windows/cross-target execution and the full HTTP integration suite were not run locally. Native builds used the hosts' configured parallelism; no SDK runtime code or installed library behavior changes.
Merge Danger
Door: two-way. Reverting restores the previous test setup.
Blast Radius: tests. The unit executable's build-tree output follows its selected helper, and CTest cases gain invocation-specific working directories. Failed fixture directories intentionally remain for diagnosis.