Repository navigation
build(ndk): Avoid stale lint results and version warnings - #2139
Merged
Merged
Conversation
The lint failure in #1725 is reproducible locally with `make -C ndk check`, even on `master`. CI on `master` happens to pass because it reuses cached `lintAnalyzeDebug` results. Fresh analysis reports dependency update notices that `warningsAsErrors` makes fatal: ```text > Task :sentry-native-ndk:lintDebug FAILED ndk/gradle/wrapper/gradle-wrapper.properties:3: Error: A newer version of Gradle than 9.7.1 is available: 9.8.0 [AndroidGradlePluginVersion] ndk/lib/build.gradle.kts:134: Error: A newer version of org.jetbrains:annotations than 23.0.0 is available: 24.0.1 [GradleDependency] ``` Disable these checks alongside `NewerVersionAvailable`. Always rerun lint analysis so CI cannot reuse a passing result when dependency metadata changes.
jpnurmi
force-pushed
the
jpnurmi/build/ndk-lint-checks
branch
from
September 29, 2026 10:10
6977b7a to
3346acd
Compare
jpnurmi
marked this pull request as ready for review
September 29, 2026 10:30
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
+ Coverage 75.36% 75.41% +0.04%
==========================================
Files 103 103
Lines 28026 28026
Branches 5114 5114
==========================================
+ Hits 21123 21135 +12
+ Misses 5571 5556 -15
- Partials 1332 1335 +3 🚀 New features to boost your workflow:
|
limbonaut
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint failure in #1725 is reproducible locally with
make -C ndk check, even onmaster. CI onmasterhappens to pass because it reuses cachedlintAnalyzeDebugresults:Fresh analysis reports dependency update notices that
warningsAsErrorsmakes fatal:Disable these checks alongside
NewerVersionAvailable. Always rerun lint analysis so CI cannot reuse a passing result when dependency metadata changes.