Mask only the shopper's name and email in session replay - #6
Merged
Merged
Conversation
The lab 2 solution used replayIntegration() with its defaults, which masks every text node, so the lab 3 replay could not show the apology the user saw. Replay now records page text, inputs, and images as rendered; the account card marks the shopper's name and email with data-sentry-mask, which stays masked when maskAllText is off. The lab 2 prompt asks for the same behaviour so an attendee's agent and the solution patch agree. Co-authored-by: Claude <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lab 2 solution called
replayIntegration()with its defaults, so every text node in the replay was masked and the lab 3 replay could not show the apology the user saw.instrumentation-client.tsin the solution patch now setsmaskAllText,maskAllInputs, andblockAllMediato false.data-sentry-mask, which stays masked because it is in the defaultmaskselector list.Verified:
git apply --checkof the regenerated patch on main passes, andtsc --noEmiton the patched app exits 0.Created with Claude Code