Repository navigation
Conversation
close #477 * Excluding 3.15 for now until dill compatibility is fixed * Also update dev python version from 3.12 to 3.14
korikuzma
added
priority:low
Contributor
|
Hmm we may be able to avoid this code path entirely, so that we can include 3.15 |
Contributor
Author
I'll defer to you. I will admit, I was being lazy |
Sqlite3MutableMapping used dill to serialize values. Nothing in the library needs dill's by-value pickling: enref/deref only stores VRS models, which pickle by reference. The only dependent was test_classes, which stored a class defined inside the test function. Move that class to module level, switch to pickle, and drop the dill dependency. dill 0.3.x also fails on Python 3.15, where code objects no longer have co_lnotab. Values written by dill for importable classes contain no dill references and load with pickle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The <3.15 cap was only needed for dill compatibility, and dill is no longer a dependency. Add 3.15 to the classifiers and CI matrix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
I'm removing |
Contributor
Author
🚫🥒 |
Targets #677. Instead of capping Python at `<3.15`, this removes the reason for the cap. 1. **build!: replace dill with stdlib pickle in object store.** Moves the test class to module level, switches `dill.dumps`/`dill.loads` to `pickle`, and drops `dill~=0.3.7` from the `extras` extra. Breaking because the dependency is removed, and because a store holding values that only dill can read (classes pickled by value) would no longer load. Values dill wrote for importable classes, such as VRS models, contain no dill references and load fine with `pickle`. 2. **build: allow python 3.15.** Removes the `<3.15` cap, adds the 3.15 classifier, and puts 3.15 back in the CI matrix. The dev Python version stays at 3.14.
theferrit32
changed the title
theferrit32
changed the title
dill dependency
theferrit32
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #477
dillwithpickle