Repository navigation
Conversation
Android 16 vendor frameworks can return SECURITY_TYPE_UNKNOWN (-1) for a successfully created WPA2-PSK group. Treat that documented value as the pre-Android-16 WPA2 assumption instead of tearing down the group and preventing wireless CarPlay from starting. Preserve explicit WPA2/WPA3 mappings and reject other unsupported values. Adapt the UNKNOWN fallback from shihabal3amri/DiPlay#121. Add API 36 regressions for successful startup and credential preservation, explicit security modes, and cleanup of unsupported values. Export the JDK FileDescriptor accessor required by Android 16 Robolectric tests. Validation: 45 related tests passed; release lint has 0 errors and 4 existing warnings; signed arm64 release built and installed. Wireless CarPlay was confirmed working by the reporter on SM-S9280 / Android 16. Fixes fython#20 Co-authored-by: Codex <noreply@openai.com>
The singleTask host cached the wireless backend and manual hotspot credentials from onCreate. Returning from settings before its controller started could therefore create a Wi-Fi Direct group after the user had selected Device hotspot, triggering Android's hotspot conflict dialog. Refresh persisted transport/backend settings on idle resume, and request startup prerequisites if the transport changed. Preserve active sessions, in-progress teardown, menu edits and transient permission prompt state. When applying a different wireless mode, wait for the old background session to stop before checking the new hotspot state. This releases the old P2P group even when the system hotspot still needs to be enabled. Add lifecycle regressions for both mode directions, edited credentials, station Wi-Fi being off, wired-to-wireless permissions and asynchronous old-session cleanup. The original code failed the first three regressions. Related validation: 90 tests passed, with the 10 directly related tests rerun against the final code; release lint has 0 errors and 4 existing warnings. Signed arm64 release, authentication assets and 16 KiB alignment verified. Co-authored-by: Codex <noreply@openai.com>
TioaChan
changed the title
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wireless CarPlay has two related startup failures:
SECURITY_TYPE_UNKNOWN (-1); WheelPlay rejects it and removes the group.Handle UNKNOWN using the same WPA2 assumption already used before API 36, with a diagnostic. Preserve explicit WPA2/WPA3 mappings and rejection of other unsupported values. Adapted from DiPlay #121.
Refresh the persisted transport, hotspot mode, and manual hotspot credentials when an idle connection screen resumes. Recheck startup permissions when the transport changes. Preserve active sessions, teardown, menu edits, and transient permission prompts. Wait for the previous background session to stop before checking and connecting with the newly selected hotspot mode.
Validation:
Fixes #20