Repository navigation
fix(deploy): bind the API port to localhost - #113
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy workflow publishes the API port as
-p ${API_PORT}:${API_PORT}, which binds0.0.0.0. Docker writes its own iptables rules, so ufw on the server doesn't apply, and port 6060 is reachable from the internet over plain HTTP, skipping nginx and TLS (verified from outside on 2026-10-28). nginx is the only thing that needs the port, and it proxies over loopback.This binds the port to
127.0.0.1indeploy.ymland indocker-compose.yamlso both stay the same.Where to look: the
docker runline in the deploy step. Webhooks still arrive throughhttps://github-bot.fullstacksjs.com→ nginx →127.0.0.1:6060.Not tested in CI: the workflow only runs on a published release. I'm recreating the running container by hand with the same flag now, and this PR keeps it that way on the next release.
Side effect for local dev:
docker compose upnow serves the port on localhost only, not on the LAN.Note
This PR is generated by Claude Opus 5.5 using Claude Code.
🤖 Generated with Claude Code