Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A parent project using
add_subdirectory(libqrencode)andtarget_link_libraries(app qrencode)cannot include<qrencode.h>without adding libqrencode's source directory manually. The library builds, but the consumer fails withfatal error: qrencode.h: No such file or directory. This affects both static and shared builds.Attach the public header directory to
qrencodeas a build-tree interface include directory. Add a CMake consumer regression that includes the public header, links only the library target, encodes a string, and frees the result. Include its source in Automake'sEXTRA_DISTso source distributions retain the CMake test.The existing tests mostly include the header using a relative path and therefore do not catch this missing target usage requirement. Subdirectory use was previously supported by #133.
Validation on Linux with GCC 14.2.0, CMake 3.11.2 and 3.31.6:
The patch received an independent review and a fresh replay of all 48 validation commands with CMake 3.31.6. Windows, macOS, CMake 3.1, PNG-enabled tools, and Autotools
make distwere not run locally. CMake 4's existing minimum-version configuration failure affects both base and fixed code and remains separate in #235.Prepared with AI assistance.