Repository navigation
fix(core): dispatch one Renamed event per group rename, and none on create - #5264
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5263
Changes proposed in this pull request:
GroupResourcesets each group name with its ownGroup::rename()call, andrename()raisedRenamedwhenever the names were dirty. So creating a group dispatchedRenamedtwice, and a rename from the admin's edit group modal, which sends both names, dispatched it twice too; Audit logged each one asgroup.renamed.rename()now raises nothing for a group that doesn't exist yet, and replaces anyRenamedalready pending, so a save dispatches at most one event with the original names.Reviewers should focus on:
groups\CreateTest, newgroups\UpdateTest) and stricter AuditCoreGroupTestassertions; all failed before the fix.Screenshot
N/A
Necessity
Confirmed
yarn testinjs/). (No frontend changes.)composer test).