Repository navigation
fix(identity): add auth_type and resource to AuthBlockingEvent - #317
Open
IzaakGough wants to merge 3 commits into
Open
IzaakGough wants to merge 3 commits into
IzaakGough wants to merge 3 commits into
Conversation
Derived from the blocking token the same way as the Node SDK, so code written from the blocking functions docs works on Python.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces AuthType and AuthBlockingResource to the identity functions, adding auth_type and resource fields to AuthBlockingEvent along with corresponding unit tests. However, there are critical issues regarding unauthenticated requests: token_data["user_record"] is accessed unconditionally which will raise a KeyError when no user record is present, and the data field in AuthBlockingEvent needs to be made optional to support these unauthenticated events properly.
IzaakGough
marked this pull request as ready for review
October 12, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #316.
AuthBlockingEventhad noauth_typeorresource, so code written from the blocking functions doc raisedAttributeError.This adds both, built from the blocking token the same way the Node SDK does.
Tested with unit tests and by running the issue's handler locally, with and without a tenant. Not tested on a deployed function.