Skip to content

Version 10.0.1 - #2553

Open
demolaf wants to merge 6 commits into
masterfrom
version-10.0.1
Open

demolaf wants to merge 6 commits into
masterfrom
version-10.0.1

Conversation

@demolaf

@demolaf demolaf commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Changes

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@demolaf
demolaf changed the base branch from master to revert/post-ga-commits November 5, 2026 12:59
@demolaf
demolaf added this pull request to stack #2554 November 5, 2026 12:59
Base automatically changed from revert/post-ga-commits to master November 5, 2026 14:59
@demolaf
demolaf removed this pull request from stack #2554 November 5, 2026 15:07
…il provider (#2551)

* fix(auth): offer no email recovery for account linking without an Email provider

The account-linking dialog's recover action always opened the email
sign-in step. With no AuthProvider.Email configured, EmailAuthScreen
called .first() on an empty provider list and crashed.

Gate the recover action on an Email provider being configured (not on
sign-up being offered, since linking signs in to an existing account),
and make EmailAuthScreen render nothing instead of throwing when a host
routes to it without one.

* fix(auth): report a missing Email provider and guard the address-in-use recovery

- EmailAuthScreen reports a MisconfigurationException through onError and
  leaves the step, instead of returning silently to an empty step.
- EmailAlreadyInUseException offers no email recovery without an Email
  provider, matching account linking.
- SignUpUI and SignInEmailLinkUI no longer call first() on the Email provider.
…hat owns the address (#2564)

* fix(auth): link a colliding provider credential through the account that owns the address

- The account-linking recovery opens the provider that owns the address:
  the opt-in legacy lookup names it when it can, a lone remaining provider
  is opened directly, and several are offered on the method picker.
- Google, Facebook and OAuth sign-ins link the pending credential before
  reporting success, and only to an account with the same address; a
  mismatch or a failed link signs back out instead of half-finishing.
- Account-linking errors carry the translated recovery message instead of
  hard-coded English.

* fix(auth): refuse an email-step sign-in at another address while a link is pending

The account-linking recovery prefills the account's address, but the field
stays editable. Signing in elsewhere would link the credential to someone
else, so the email step now refuses before signing in, as the provider
flows do after.

* fix(auth): keep the account-linking recovery all or nothing on every path

- Only a sign-in through a provider the recovery offered finishes the
  link; any other, such as phone, drops it instead of being refused.
- A mismatched account the sign-in only just created is deleted rather
  than left behind; a cancelled link signs back out.
- The email step links the recovery's credential all or nothing, and the
  email-link step is held to the account's address too.
- The provider credential a collision saved for a later email-link
  sign-in is forgotten once the recovery's link ends.

* fix(auth): close the remaining gaps in the account-linking recovery

- A mismatch undone while cancelled still signs out.
- An email-link sign-in counts as the Email provider, so it finishes
  the recovery's link instead of dropping it.
- A linking error with no credential keeps the link already pending.
- The credential saved for email-link sign-in is forgotten where the
  link resolves, not only from the screen.
- No provider recovery when the collision names no address.
- The email step merges the linked provider's profile again.

* fix(auth): keep the account-linking recovery through recreation, lookups and auto-select

- The pending link is saveable, so an Activity recreated while the
  owner's sign-in UI is open still finishes the link.
- The opt-in owner lookup shows loading, so no second sign-in can
  start while it runs.
- Google auto-select is off while a link is pending, so a wrong pick
  is not handed back again.

* docs(auth): restore the getStartRoute KDoc above its function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants