ES: convert province by province, then merge - #338
ivorbosloper wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Does it handle collectio metadata correctly? Especially creating columns for e.g. different data colimng from there? License, variant/state/kanton, etc? Ideally it mimics what vec merge does and can be used as a generic replacement as vec merge in geopandas will be an issue anyway in the long run. |
|
Good point. There's a bug in |
|
Fix: vecorel/cli#55. Checked on two real provinces: |
|
I'll wait with making this a Non-Draft PR, it needs a vecorel dependency update due to vecorel/cli#55 |
esnow converts each of its 50 provincial GeoPackages on its own and merges the parts, because the whole of Spain does not fit in memory in one run. Closes #336.PerFileConverterMixin(fiboa_cli/conversion/per_file.py) runs the normalconvertonce per source file into a temporary part, then merges the parts with vecorel-cli'sDuckDBBaseConverter.merge_parquet, which checks the ids and Hilbert-sorts over the whole set. With a single source file it is plainconvert. It replaces the 450-linePerFileBaseConverterof PerFileBaseConverter: convert file by file, then merge #281.DuckDBBaseConverterrather than mixing that class in, so the converter's ownconvertchain stays as it is.~nsuffix, as before.🤖 Generated with Claude Code