Replace fiboa publish with the Portolan workflow - #337
Open
ivorbosloper wants to merge 2 commits into
Open
ivorbosloper wants to merge 2 commits into
ivorbosloper wants to merge 2 commits into
Conversation
The README now describes the steps, written for an agent to follow; create-stac-collection stays, to seed the collection metadata. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…om its data survey Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ivorbosloper
marked this pull request as ready for review
September 25, 2026 20:06
m-mohr
approved these changes
Sep 26, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the missing fiboa property descriptions and the documented validation, URL mapping, and changelog inconsistencies.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Replaces fiboa publish with a documented Portolan publishing workflow and enhances STAC property descriptions.
Changes:
- Removes the publisher, command registration, tests, and fixture.
- Documents the Portolan publishing process.
- Adds fiboa property descriptions to STAC collections.
- Updates the changelog.
| File | Description |
|---|---|
tests/test_publish.py |
Removes obsolete publisher tests. |
tests/test_create_stac.py |
Tests STAC column descriptions. |
tests/test_command_modules.py |
Verifies publish is absent. |
tests/data-files/publish/BE-VLG-survey.md |
Removes obsolete fixture. |
README.md |
Documents the Portolan workflow. |
fiboa_cli/registry.py |
Removes command registration. |
fiboa_cli/publish.py |
Removes obsolete publishing implementation. |
fiboa_cli/create_stac.py |
Adds fiboa column descriptions. |
CHANGELOG.md |
Records the removal and STAC changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+11
to
+15
| DESCRIPTIONS = { | ||
| "id": "Unique identifier", | ||
| "collection": "The collection identifier", | ||
| "inspire:id": "The INSPIRE identifier", | ||
| "determination:datetime": "Timestamp of the determination of the field boundary", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
fiboa publishand documents publishing as a Portolan catalog in the README, step by step, so that an agent can follow it. Closes #335. This means we don't have a program that publishes data, but only an agent description. But I think this is the way, we can always restore some program if we need it....fiboa create-stac-collectionstays. It is the source of what Portolan cannot read from the file: title, description, providers, license and fiboa version. Written ascollection.jsonbeforeportolan add, these fields survive the merge (checked with portolan 0.8). The assets are dropped first, because Portolan adds its own asset with checksum and size.create-stac-collectionnow describes the fiboa properties intable:columns, using the fixed descriptionspublish.pyhad for its README. The README step moves those columns to the collection, whereportolan readmerenders them.fiboa publishread from the data survey is now a README step: a table maps the survey's fields to Portolan'smetadata.yaml, and the survey's Properties table describes the dataset's own columns.requests,clickandspdx-license-listare imported elsewhere.🤖 Support from Claude Code