Skip to content

REST converters: survive a tired service - #328

Merged
m-mohr merged 2 commits into
mainfrom
rest-retry
Sep 25, 2026
Merged

m-mohr merged 2 commits into
mainfrom
rest-retry

Conversation

@ivorbosloper

@ivorbosloper ivorbosloper commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

REST converters retry every request a run depends on (service and layer metadata, id bounds, pages) instead of ending on the first refusal, and read a joined layer's key field from the layer's metadata.

@ivorbosloper
ivorbosloper marked this pull request as ready for review September 24, 2026 20:29
@ivorbosloper
ivorbosloper requested a review from m-mohr September 24, 2026 20:29
Retry the service metadata, the layer metadata, the id bounds and every
page through one helper (8 attempts, backoff capped at 30 s), and read a
joined layer's key field from the layer's own metadata instead of a
one-row "where=1=1" probe, which es_ib refuses on its joined views.

Ports 1f28b73, a1f4dda, f8aea60 and 545ada0 from #214 onto the window
cache scheme of #232.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread fiboa_cli/conversion/converter_rest.py
Comment thread fiboa_cli/conversion/converter_rest.py Outdated
@m-mohr

m-mohr commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

@ivorbosloper Applied some improvements to the REST handling. I think it's looking much more robust now.

This comment was marked as resolved.

@m-mohr
m-mohr requested a balanced review from Copilot September 25, 2026 11:20

This comment was marked as resolved.

This comment was marked as resolved.

…d a 3-minute timeout, and fetch unreadable cached pages again

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The resilience changes are coherent, bounded, and covered by targeted tests.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@m-mohr
m-mohr merged commit 2fb3f85 into main Sep 25, 2026
8 checks passed
@m-mohr
m-mohr deleted the rest-retry branch September 25, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants