EC-BE-VLG, ES and IE-LPIS convert correctly again - #327
Merged
Merged
Conversation
ivorbosloper
marked this pull request as ready for review
September 24, 2026 20:28
m-mohr
reviewed
Sep 25, 2026
m-mohr
reviewed
Sep 25, 2026
ivorbosloper
force-pushed
the
fix-ec-be-vlg-es-codelist
branch
from
September 25, 2026 10:33
9e3b3ef to
e0530a1
Compare
ivorbosloper
changed the title
- ec_be_vlg: drop the variants inherited from be_vlg, which vecorel refuses next to sources - es: map PARC_PRODUCTO to HCAT with fiboa.org/code/es/es.csv; the old code list URL was a 404 - test that no converter declares both sources and variants Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
m-mohr
force-pushed
the
fix-ec-be-vlg-es-codelist
branch
from
September 25, 2026 11:01
70af61d to
f9c916c
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add end-to-end and HCAT output assertions for EC-BE-VLG, ES, and IE-LPIS.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Fixes converter configuration and HCAT mapping regressions for EC-BE-VLG, ES, and IE-LPIS.
Changes:
- Corrects EC-BE-VLG source and variant handling.
- Adds or restores HCAT mappings for ES and IE-LPIS.
- Relaxes single-category HCAT validation and adds regression checks.
| File | Summary |
|---|---|
tests/test_converters.py |
Adds converter regression checks. |
fiboa_cli/datasets/ie_lpis.py |
Restores the HCAT mapping configuration. |
fiboa_cli/datasets/es.py |
Enables HCAT mapping for Spain. |
fiboa_cli/datasets/ec_be_vlg.py |
Removes inherited yearly variants. |
fiboa_cli/datasets/commons/hcat.py |
Allows single-category mappings. |
CHANGELOG.md |
Documents the converter fixes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+12
to
+13
| # the single EuroCrops 2021 release, not the parent's yearly editions | ||
| variants = {} |
m-mohr
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken
ec_be_vlgandesconverters, taken from #214, andie_lpis, which still setec_mapping_csvafter #320 and so lost its HCAT mapping. A new test catches that old name.