Fix flaky test in login.test.ts (normalizes CLI login origins and preserves the allowlist) - #110
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dodok8
force-pushed
the
109/cli-login-test
branch
from
October 6, 2026 07:18
1d9aa84 to
8a6018c
Compare
sij411
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a testbed PR to measure CLI login integration test timing and investigate intermittent CI failures.
Related to #109.
How to check
Result
Single tests takes times about 3.21 - 6.89 secs, multiple pararell tests takes about 28 secs. Previous 30 secs limit is not appropriate, even though test is event-driven, it fails before check all events.
However, just in case, an upper limit is necessary to prevent any potential infinite loop errors from causing the entire test to fail due to a timeout. This PR resolves flakiness based on experimental data by changing the existing upper limit to 2 minutes.
AI assistance
Codex reviewed the test and CI configuration, created empty commits at the maintainer’s request, and collected CI timing samples.