fix(compute): correct confusing error for invalid fastly.toml - #1916
Open
WhiteAbeLincoln wants to merge 1 commit into
Open
WhiteAbeLincoln wants to merge 1 commit into
WhiteAbeLincoln wants to merge 1 commit into
Conversation
WhiteAbeLincoln
force-pushed
the
abe/file-not-found-error
branch
from
September 25, 2026 23:03
d644a60 to
9b8566c
Compare
When a fastly.toml file is present but missing a `name` field, the `fastly compute deploy` command would return a confusing "file not found" error. This was due to the use of the `ErrReadingManifest` error, which was previously used for all sorts of manifest errors, but the wording was changed PR #1556 to be specific to not found errors. The fix is to return a `ErrMissingManifestName` in these situations, and we additionally ensure that the `--package` flag remediation is returned wherever it is relevant.
WhiteAbeLincoln
force-pushed
the
abe/file-not-found-error
branch
from
September 25, 2026 23:05
9b8566c to
16df293
Compare
WhiteAbeLincoln
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
When a fastly.toml file is present but missing a
namefield, thefastly compute deploycommand would return a confusing "file not found" error. This was due to the use of theErrReadingManifesterror, which was previously used for all sorts of manifest errors, but was changed but the wordingwas changed PR #1556 to be specific to not found errors
The fix is to return a
ErrMissingManifestNamein these situations, and we additionally ensure that the--packageflag remediation is returned wherever it is relevant.All Submissions:
Changes to Core Features:
User Impact
Fixes confusing error, which admittedly only occurs in rare cases.
Are there any considerations that need to be addressed for release?