Repository navigation
Disable the test runner for parallel-letter-frequency - #1050
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
iHiD
added a commit
to exercism/cpp-test-runner
that referenced
this pull request
Oct 22, 2026
TBB was only used by the parallel-letter-frequency exercise, whose test runner exercism/cpp#1050 disables. Co-authored-by: Michael Allwright <contact@allwright.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
vaeng
approved these changes
Oct 24, 2026
Contributor
|
@siebenschlaefer and @ahans: deprecation is better if it is not tested imo. What do you think? |
Contributor
|
@vaeng I agree |
IsaacG
approved these changes
Oct 26, 2026
vaeng
pushed a commit
to exercism/cpp-test-runner
that referenced
this pull request
Oct 26, 2026
TBB was only used by the parallel-letter-frequency exercise, whose test runner exercism/cpp#1050 disables. Co-authored-by: Michael Allwright <contact@allwright.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
iHiD
added a commit
to exercism/cpp-test-runner
that referenced
this pull request
Oct 27, 2026
* Remove TBB TBB was only used by the parallel-letter-frequency exercise, whose test runner exercism/cpp#1050 disables. Co-authored-by: Michael Allwright <contact@allwright.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Make run.sh POSIX sh * Fix run-tests.sh and drop std::ptr_fun run-tests.sh checked $? after the rm that cleaned up the temporary files, so it saw the exit status of rm and the suite never failed on a mismatch. It now checks the result of diff directly. The line-number pattern used \d, which sed does not understand, so line numbers were never normalised. It now uses [0-9]\{1,\}. std::ptr_fun and std::not1 were removed in C++17, so helpers.h now uses a lambda instead. Co-authored-by: Michael Allwright <contact@allwright.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Compare build errors by status only The expected results stored the exact compiler output, which changes with every compiler upgrade. For example, example-empty-file was recorded with GCC 12.2.1 in 2023 and the image now has GCC 15.2.0. Build errors are now compared by their status, so the suite no longer breaks when the compiler changes. Co-authored-by: Michael Allwright <contact@allwright.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Add client-side runner (#106) * Add client-side runner * Fix comments in client-side scripts * Rewrap comment, bump configure-aws-credentials to v6.3.0 * Handle staged kernels and sysroots --------- Co-authored-by: Michael Allwright <contact@allwright.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Discord discussion, this disables the Parallel Letter Frequency exercise from being run in our test infrastructure. I don't have a preference about whether we deprecate it or not - I'll leave that to maintainers 🙂
🤖 Generated with Claude Code