Repository navigation
fix(interpreter): admit concurrent pipeline forks - #2722
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 093fbf7 | Commit Preview URL Branch Preview URL |
Oct 14 2026, 02:26 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Streaming pipeline producers now claim the shared concurrent-job capacity before construction. Owned fork state, pipe metadata, producer vectors and future layouts reserve the request storage budget before allocation. Stage commands borrow the existing AST, and immutable environment/Git configuration stays shared. Cancelled-request cleanup releases retained pipe references.
Why
Eager producer construction previously bypassed live-job admission and storage accounting. Pipe backpressure only begins after construction, so it cannot protect this boundary.
Before / After
Two ordinary
{ :; } | :admission fixtures failed before the repair: an occupied shared job slot did not reject producer construction, and a zero storage budget did not reject retained fork storage. After the repair both return typed errors before forking.Seven focused unit fixtures and four ordinary two-stage integration fixtures pass. They cover shared admission, environment ownership, cancellation, drop/reconciliation cleanup, supplied stdin, session reuse, export isolation, sequential mode, lastpipe and a real-Bash comparison. Exact local CLI smoke prints
okfollowed by0 0for PIPESTATUS.Risk
max_background_jobs; accepted pipelines preserve streaming and isolation. Previously accepted pipelines may return a resource-limit error under a low configured cap.Checklist
Validation
Focused fixtures, workspace Clippy/tests, Git-feature compilation, formatting, all 162 script tests, capability/workflow/changelog/OKF/doc-link checks, cargo vet and rustdoc compilation pass. The pre-PR run initially lacked PyYAML locally; its remaining stages passed after installing PyYAML in an isolated build virtualenv. The reported exhaustion payload was not reproduced. Focused proof uses tiny ordinary inputs. Normal repository quality gates and required CI run under the user's subsequent approval; separate live-provider experiments and production changes remain outside this repair.
Performance validation: the standard Criterion parallel-execution benchmark completed. The ordinary 96-case Bashkit-vs-Bash corpus completed on both latest-main baseline and repair with zero errors and 100% expected-output matches. Aggregate Bashkit mean time was 25.70 ms versus 26.26 ms (+2.2%); the native-Bash control varied +7.1%. These short-run timings are observational; full per-case samples are retained locally.