Skip to content

fix: remove unresolved Private DvP placeholder - #203

Open
arunimshukla wants to merge 1 commit into
ethsystems:masterfrom
arunimshukla:fix/remove-private-dvp-placeholder
Open

arunimshukla wants to merge 1 commit into
ethsystems:masterfrom
arunimshukla:fix/remove-private-dvp-placeholder

Conversation

@arunimshukla

Copy link
Copy Markdown
Contributor

What are you adding?

  • Vendor/Protocol
  • Enterprise Use Case
  • Update to existing content
  • Other

Description

I removed the unresolved Private DvP (link missing) entry from the Trading domain.

I checked the current use case inventory and could not identify a canonical Private DvP destination. Rather than add an unverified relationship, I removed the placeholder and left the existing Private Bonds link unchanged.

I also validated the change locally with npm run validate:ci, npm run check-terms:ci, and git diff --check.

Checklist

  • I've checked this doesn't duplicate existing content
  • All links work
  • Info is accurate

Comment thread domains/trading.md
@@ -10,7 +10,6 @@ description: "Execute and settle without leaking intent, size, or counterparties
- Cross-domain atomicity (DvP/PvP) without HTLCs; optional zk-SPV for strong atomicity.

## Primary use cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can link to private stablecoins here

@arunimshukla arunimshukla Sep 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d use Private Repo instead of Private Stablecoins here.

  • private-repo.md is explicitly tagged primary_domain: Trading. private-stablecoins.md is tagged primary_domain: Payments. So the repo’s own taxonomy already puts Repo in the exact domain this page represents.

  • Private Repo is structurally closer to DvP because repo settlement is an asset-versus-cash transaction and the page already points to atomic settlement and DvP patterns.

  • Private Stablecoins are better understood as the cash part of a trade, not the trade use case itself. The stablecoin page supports settlement across multiple domains, especially Payments.

  • The Trading domain already has a separate “Related use cases” section. Stablecoins fit better there as supporting settlement infrastructure, while Repo fits naturally as a primary Trading use case.

  • Private Stablecoins are already a primary use case under Payments. Using it again as the main Trading entry weakens the taxonomy; using Private Repo keeps each domain anchored to a use case that actually belongs there.

If that makes sense, I’ll update the PR to link Private Repo here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree Repo seems to fit better than Stablecoins here. Note, however, that Private Stocks and Private Commodities are also primary_domain: Trading, so all three should be listed rather than just Repo.

Having said that, there's the underlying question of how accurate current tags are. There may be some drift wrt existing knowledge and understanding. In particular, "Private DvP" already appears in the map as Approach: Atomic DvP Settlement (approaches/approach-dvp-atomic-settlement.md).
MAybe an Approaches section (like governance.md and identity-compliance.md) linking that approach and Private Trade Settlement can be interesting.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I checked the current front matter and Trading has three primary use cases today:

  • Private Repo,
  • Private Stocks, and
  • Private Commodities,

so I’ll update the section to include all three.

I also checked the wider mapping and there does appear to be some taxonomy drift. Five use cases currently declare secondary_domain: Trading, Private FX, Private Read, Private Messaging, Private Corporate Bonds, and Private Oracles, while domains/trading.md currently lists only Private Bonds under its secondary section. private-bonds.mditself does not declare Trading as a secondary domain.

I’ll keep this PR scoped to two concrete changes:

  1. Align the primary use-case list with the existing frontmatter.

  2. Add an Approaches section linking Atomic DvP Settlement and Private Trade Settlement, following the structure already used in governance.md and identity-compliance.md.

I can take the broader domain/use-case mapping as a separate follow-up once this is merged, rather than mixing a taxonomy cleanup into the current fix.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, sounds good!

@rymnc
rymnc self-requested a review September 28, 2026 12:43
@oskarth
oskarth removed their request for review October 1, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants