Repository navigation
Support trusted reverse proxies in on-prem installs - #106
Open
marekmelichercik wants to merge 3 commits into
Open
marekmelichercik wants to merge 3 commits into
marekmelichercik wants to merge 3 commits into
Conversation
shrkz1
approved these changes
Nov 2, 2026
shrkz1
left a comment
Member
There was a problem hiding this comment.
Pôvodná požiadavka je splnená: štandardná Docker inštalácia má prednastavenú adresu Caddy a Apache ju automaticky dôveruje aj pri staršom .env bez nových premenných. Vlastné adresy a upstream proxy sa nastavujú len pri upravenom deploymente.
Prešiel som celý diff voči 1.x a na tomto SHA spustil všetkých 16 Bats testov; prešli. Community CI je zelené. Nenašiel som blokujúci nález. Enterprise som overil cez Compose konfiguráciu a testy, nie samostatným runtime nasadením.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Standard on-prem installations previously left Apache proxy trust disabled and required operators to discover Caddy's address manually. Configure the bundled Caddy with a reserved address and make Apache trust that address automatically, building on the shared image's client-IP fix from https://github.com/eramba/eramba/pull/6276.
The internal network defaults to
172.30.50.0/24, with dynamic allocations restricted to172.30.50.128/25and Caddy reserved at172.30.50.10. Operators can overrideAPP_INTERNAL_SUBNET,APP_INTERNAL_IP_RANGEandPUBLIC_PROXY_IP. The samePUBLIC_PROXY_IPcontrols Caddy's address and Apache's default trust. The internal-network flag and Caddy's host-access connection remain intact.Missing or empty
TRUSTED_PROXIESselects the bundled Caddy address, including with older .env files. A nonempty comma-separated list replaces that default and must include Caddy plus any preserved trusted proxy hops. The separate space-separatedCADDY_TRUSTED_PROXIESlist still defaults to empty and names only external proxies before Caddy. Caddy parses trusted chains from right to left; Apache resolves its trusted hops and canonicalizes X-Forwarded-For before PHP. Enterprise inherits the shared configuration.README covers automatic defaults, custom-network examples, external load balancers, and an explicit Compose override for disabling Apache trust. Existing installations need a maintenance-window network recreation without deleting volumes; the documented procedure preserves project/volume identity and accounts for subnet conflicts and older static-IP overrides. Ordinary Caddy recreation no longer requires rediscovering its IP.
Validation:
Requires an Eramba image containing the Apache client-IP fix (3.31.1 or later). This PR does not change Laravel proxy handling, deploy SaaS infrastructure, or rewrite historical IP records.