CLI: Fix silent interactive TUI hang when project is inferred from CWD - #414
Open
abelbriggs1 wants to merge 3 commits into
Open
abelbriggs1 wants to merge 3 commits into
abelbriggs1 wants to merge 3 commits into
Conversation
If a job runs into an error case before calling `update_status()`, the job will never be considered 'completed' and the polling thread will never wake. Handle this by always waking at the end of the job.
Previously, if a job failed, the terminal would not give any feedback, showing a blank display. Handle this by printing the job status instead.
The CLI naturally infers the location of the project file/directory via either CLI arguments or the current working directory. `run_interactive()`, however, always populates the project dir from the `-p` argument. If the project dir is inferred via CWD, this fails. Route the inferred project dir from the caller instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #404.
See commits for full details on the changes.
828d6f524fb0d45f03aeefa3d636e762ec698796is the primary fix here.The other two commits were made while trying to debug the root cause. They should still be valid fixes, though the implementation might not be ideal (I am not experienced with Rust concurrency at all).