Skip to content

Document FreeType font behavior #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobsingor merged 1 commit into from
Oct 13, 2026
Merged

Document FreeType font behavior #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions docs/embedpdf/fork-ledger.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,11 @@ text markup reads oriented quads.
**Rule.** Glyph bounds of substitute fonts are measured as drawn, including multiple-master design
changes.
**Why.** Text bounds of substituted fonts came out wrong, while renders were right.
**Where.** `cfx_face.cpp`.
**Where.** `cfx_face.cpp`, inside upstream's `PDF_ENABLE_FREETYPE` guards: the scoped variation
calls FreeType.
**Guarded by.** `epdf_text_bounds_embeddertest.cpp`.
**When upstream touches this.** `CFX_Face` metrics.
**When upstream touches this.** `CFX_Face` metrics, and the FreeType and Fontations branches of
`CFX_Face`.

## Annotations, forms and features

Expand Down Expand Up @@ -385,7 +387,9 @@ expect standard fonts from the test fonts, so the embedder test environment turn
`EPDFViewEmbedderTest.StandardFontsDrawWithBuiltInFaces` for standard fonts.
**When upstream touches this.** Font loading and mapping. A new upstream test that expects the test
fonts for a standard font passes as it is; one of ours that expects the built-in faces turns the
switch off.
switch off. Our font code calls FreeType directly (`CFX_Face::GetFsTypeFlags()`, CID-keyed CFF,
the registry), so our builds keep `pdf_enable_freetype` on; a Fontations-only build would need
Skrifa versions of them.

### measurement
**Rule.** Measurement dictionaries and dimension appearances.
Expand Down
2 changes: 1 addition & 1 deletion docs/embedpdf/syncs/2026-10-13-06fbf69b3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ None. The darwin-arm64 exports are S8's (1150 symbols).

## Ledger changes proposed

For review; none applied.
Both approved on Oct 13 and applied after the merge, in `fork-ledger.md`.

1. **substitute-font-bounds, Where:** "`cfx_face.cpp`, inside upstream's `PDF_ENABLE_FREETYPE`
guards: the scoped variation calls FreeType." **When upstream touches this:** add "the FreeType
Expand Down