Repository navigation
benchpod: module(), set_module_id() and Calibration.stored - #67
Merged
Merged
Conversation
The analog module of a two-board BenchPod (digital v3r3) carries an EEPROM with its identity and, from firmware 3.10.1, its calibration. - ModuleInfo + BenchPod.module(): the module, its rails and EEPROM state. - BenchPod.set_module_id(serial, rev, module_type, replace=False): writes the identity, keeps the calibration, refuses to change an existing serial unless replace=True. - Calibration.stored: "module", "pod" or "none" (None on older firmware). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analog module of a two-board BenchPod (digital v3r3) carries an EEPROM with its identity and, from firmware 3.10.1 (embeddedci-com/benchpod-firmware#133), its calibration.
ModuleInfoandBenchPod.module(): the module, its two rails, the EEPROM state, type, revision, serial and the stored calibration blob.BenchPod.set_module_id(serial, rev, module_type="analog", replace=False): writes the identity, keeps the calibration, and refuses to change an existing serial unlessreplace=True(a serial names one module for life). Validates the serial (1-16 printable characters) and the revision ("major.minor").Calibration.stored:"module","pod"or"none";Noneon older firmware.tests/test_module.py).Checked against benchpod-c2f662 with a dev build of the firmware branch:
module()read the header the firmware created when it copied the calibration over (empty serial,cal_len124,cal_ok), andcalibration().storedreadmodule. ship-pod then wrote the ID (am-46d70394add9, rev 3.3) with the raw command.The two
test_aivision.pyfailures also fail on main (they need the camera rig).🤖 Generated with Claude Code