Repository navigation
capture_la: document and test the refusal of a rate that does not fit (firmware 3.10.0) - #65
Merged
Merged
Conversation
… (firmware 3.10.0) Firmware 3.10.0 refuses an explicit LA rate a capture cannot run at instead of slowing it down. The e2e rate test leaves the rate out for its deep cases (the pod picks the fastest that fits and reports it), and a new test checks the refusal names the limits (skipped on older firmware). The capture_la docstring says what happens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firmware 3.10.0 (embeddedci-com/benchpod-firmware, la-rate-refuse-explicit) refuses an explicit LA rate a capture cannot run at instead of slowing it down, with a message naming the most samples at that rate and the fastest rate for that depth.
test_la_reports_the_rate_it_achieved: the deep cases leave the rate out (the pod picks the fastest that fits and reports it); the reported rate is still checked against an FPGA-timed 50 kHz train.test_la_rate_that_does_not_fit_is_refused(skipped below firmware 3.10.0).capture_ladocstring says what happens.Both pass on benchpod-30a9f1 with the 3.10.0 build (5 passed).
🤖 Generated with Claude Code