use :prefix to query attached databases

[mochaaP]

Reverts "raise on table prefixes" (71ddd0a, 7882a01, #103).

Supersedes #175, thanks @sbaildon.

[mochaaP]

to maintainers: you may also want to pick changes from mochaa/main.

[mochaaP]

f41a2de (HEAD -> main, mochaa/main) Support modifiers and drop mode
14b616f Stricter testing for raised error messages
4942046 Support table-level check constraints
61cdfa3 Fix incorrectly named BinaryUUIDTest that didn't get loaded
aa13a6f Remove deprecated parentheses after field access usage in tests
ad3b608 (mochaa/mochaa/prefix, mochaa/prefix) use :prefix to query attached databases

[warmwaffles]

Not really a breaking change. If someone was relying on that obscure function on the adapter from their application. That's a them problem. 🤣

Suggested change

	- changed: **breaking** Made quote_name/1 private.
	- changed: Made `quote_name/1` private.

[mochaaP]

agree. 🤪

[warmwaffles]

Is there any way on the integration side you can add a prefix test or two specifically for sqlite. I just want to make sure this functionality works and stays working going forward. You are free to construct schemas and stuff however you want for it.

[mochaaP]

Is there any way on the integration side you can add a prefix test or two specifically for sqlite. I just want to make sure this functionality works and stays working going forward. You are free to construct schemas and stuff however you want for it.

in integration_test/? sure, will do later.

[warmwaffles]

Yes, anywhere in there is fine with me. Construct it however you want.

[mochaaP]

not sure how should I do that, ATTACH DATABASE is per connection and current test repo pool size is 5

[warmwaffles]

Actually that migration test should be sufficient enough since that's executed in the integration tests.

[mochaaP]

also tests are a bit flaky because sqlite expects single writer.

[mochaaP]

well, does this count?

defmodule Ecto.Integration.PrefixTest do
  use Ecto.Integration.Case, async: true

  import Ecto.Query, only: [from: 2]

  alias Ecto.Integration.Post
  alias Ecto.Integration.TestRepo

  test "queries an attached database through :prefix" do
    TestRepo.query!(~s|ATTACH DATABASE ":memory:" AS "foo"|)
    TestRepo.query!(~s|CREATE TABLE "foo"."posts" AS SELECT * FROM "main"."posts"|)

    TestRepo.insert!(%Post{id: 1}, prefix: "foo")

    results =
      from(Post, prefix: "foo")
      |> TestRepo.all()

    assert [%Post{id: 1}] = results
  end
end

[warmwaffles]

Yea that works