Repository navigation
utility-meter: wait for the configured broker under ebus-service-discovery 0.5.0 - #105
Merged
Merged
Conversation
…overy 0.5.0 0.5.0's discovery-with-fallback returns the configured broker when the broker it hears is a different one, so the discovery loop fell back on the first browse that heard any broker. Use match_configured() and keep browsing until the configured broker is heard or --discover-timeout ends. Raise the mdns extra's floor to 0.5.0 and correct the README and CHANGELOG description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T32pvgqCzp1qCz7K5gS9Wm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utility-meter --discoverwith ahostin the broker config now uses only a discovered broker that is that host, and keeps browsing until it is heard or--discover-timeoutends, then falls back to the config's host. Under ebus-service-discovery 0.5.0 the old loop fell back as soon as it heard any other broker. With nohost, the first ranked broker is used, as before.The
mdnsextra's floor rises toebus-service-discovery>=0.5.0(formatch_configured()), andexamples/README.mdand the unreleased CHANGELOG entries now describe this.Checked with a stubbed browse: configured broker heard -> it is used; configured broker absent -> discovery returns nothing and the meter falls back to the config's host; no
host-> the first broker found. 873 tests pass; ruff check and format pass, including the extension-less example.🤖 Generated with Claude Code
https://claude.ai/code/session_01T32pvgqCzp1qCz7K5gS9Wm