Repository navigation
Add the ebus_homie target; ebus_core becomes an umbrella - #12
Merged
Merged
Conversation
The Device, Node and Property model, /set dispatch, the controller, ids, datatypes, limits, JSON helpers, the HomieTransport adapter, and the log and clock hooks move to homie/ (include/ebus/homie/, src/). ebus_homie links ebus_mqtt and ArduinoJson and nothing else; mqtt/ and discovery/ use neither hook, so log and clock stay with the Homie model. ebus_core becomes an INTERFACE target linking ebus_mqtt, ebus_discovery and ebus_homie. The tests and the POSIX port include the new paths; the Homie suites link ebus_homie alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Npk6WmkpnBRzWkuhK6uCuz
include/homie/*.h and include/util/jsonUtils.h forward to ebus_homie, so esp32-sdk's #include <homie/Device.h> and the like keep compiling. The ebus_core umbrella and the PlatformIO library put include/ on the path. esp32-sdk's generator parses include/homie/homie_limits.h for the four base id and topic limits, so that forwarder repeats them. A repeated #define that differs from ebus/homie/homie_limits.h is a macro redefinition warning, an error under the CI's warnings-as-errors build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Npk6WmkpnBRzWkuhK6uCuz
…clude directories only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Npk6WmkpnBRzWkuhK6uCuz
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Npk6WmkpnBRzWkuhK6uCuz
3 tasks done
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last of the three components: the Homie model moves to
homie/asebus_homie, andebus_corebecomes an umbrella.ebus_homie/setdispatch, controller and inbox, ids, datatypes, limits, enums, descriptor, vocabulary, JSON helpers,HomieTransport, log, clock, topicebus_mqtt, ArduinoJsonebus_coreebus_mqtt,ebus_discovery,ebus_homie; carriesinclude/(pre-split paths)mqtt/anddiscovery/:homie/include/ebus/homie/,homie/src/,homie/CMakeLists.txt(standaloneadd_subdirectory(<path>/cpp-sdk/homie)addsebus_mqtttoo),ebus_homie_header_check, CI step "ebus_homie alone" (-I homie/include -I mqtt/includeplus ArduinoJson),library.jsonsrcFilter and-I homie/include. Files keep their names;util/jsonUtils.hbecomesebus/homie/jsonUtils.h.ebus_homie: nothing inmqtt/ordiscovery/calls them, so a shared base target would have no second user.include/homie/*.handinclude/util/jsonUtils.hforward to the new paths, so esp32-sdk's#include <homie/...>builds unchanged. esp32-sdk's generator regex-parsesinclude/homie/homie_limits.hfor the four base limits, so that forwarder repeats those#defines; a value that differs fromebus/homie/homie_limits.his a macro redefinition warning (an error in CI).git log --followreaches each file's history.<ebus/homie/...>; every suite other thantest_mqtt_*andtest_discovery_*linksebus_homiealone.Closes #3
🤖 Generated with Claude Code
https://claude.ai/code/session_01Npk6WmkpnBRzWkuhK6uCuz