Repository navigation
Let a port force $description out on a recovery republish - #10
Merged
Merged
Conversation
Device::publish() skips a $description identical to the last one sent, which blocks every recovery republish after a broker lost its retained store. Device::forgetDescriptionHash() clears the remembered hash for one device, so the next publish() sends it; notifyStructuralChange() keeps its no-op skip. The POSIX demo device now republishes the whole tree on every reconnect with the hashes forgotten (was publishStateTree()): with a clean session it cannot tell whether the broker kept its retained store. The reconnect e2e test checks that root and child $description are retained again after a broker restart without persistence. doc/core.md documents the recovery path; doc/mqtt.md now lists esp32-sdk's MqttClientTransport under the generic queue_publish() override. Fixes #9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Npk6WmkpnBRzWkuhK6uCuz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9.
API
Device::forgetDescriptionHash()clears the remembered$descriptionhash of one device, so its nextpublish()sends$descriptioneven if unchanged.clearRetained()now calls it.notifyStructuralChange()keeps its no-op skip.POSIX port
On every reconnect the demo device calls
forgetDescriptionHash()on each device and thenpublishTree()(waspublishStateTree()): each device goes init,$description, values, ready, children first. The port uses a clean session and MQTT reports nothing about the retained store, so it cannot tell a broker restarted without persistence from one that kept everything; a held-publish loss signal alone would miss that case (the restart in the e2e test evicts nothing). The cost is one init/ready cycle and one$descriptionper device per reconnect. A mutex now covers the uptime worker's store and queue, since the reconnect republish reads that property on the main thread.Docs
doc/core.md: new "After a reconnect" section.doc/mqtt.md: esp32-sdk'sMqttClientTransportoverrides the genericqueue_publish()(since esp32-sdk #76), not the Property overload.Tests
test_device_lifecycle: repeatedpublishTree()and a no-opnotifyStructuralChange()send no$description; afterforgetDescriptionHash()both devices send it, then skip again; forgetting one device affects only that device; a failed forced publish is retried.e2e_reconnect: after a mosquitto restart withpersistence false, a client that subscribes late receives retained root and child$description. This assertion fails against the previous device code ("no retained ebus/5/e2e-dev/$description after the restart") and passes now (5 of 5 repeats).ebus_mqttandebus_discoveryisolated compiles; esp32-sdkmainwithlib/ebus_coreat this commit:./ebus-esp32 build(esp32-poe-iso) and./ebus-esp32 test(13 suites) pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01Npk6WmkpnBRzWkuhK6uCuz